Context Navigation

Ticket #10626 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Use spectrum selection from Apply Corrections in other Indirect preview plots

Reported by:	Dan Nixon	Owned by:	Dan Nixon
Priority:	major	Milestone:	Release 3.3
Component:	Indirect Inelastic	Keywords:
Cc:	spencer.howells@…	Blocked By:	#10492
Blocking:		Tester:	Harry Jeffery

Description (last modified by Dan Nixon) (diff)

Out of all the preview plots that have been added th way the apply corrections one works is quite nice (i.e. using a spinner for spectrum selection and having a curve legend).

For IDA:

For MSDFit, FuryFit, ConvFit:
- Change plot spectrum and spectra range to spinners
- Add a plot legend (black=sample, red=fit)
For Elwin
- Add a combo box to allow the user to select an input workspace to preview
- Add a spinner allowing selection of the preview spectrum

For IDR:

For Transmission:
- Add plot legend (black=can, red=sample, green=transmission)
For Diagnostics and Calibration:
- Add raw plot spectrum selection (via property tree)

Attachments

irs26173_graphite002_elwin_eq2.nxs (120.5 KB) - added by Dan Nixon 6 years ago.: Test file for MSD fit
irs26176_graphite002_iqt.nxs (119.4 KB) - added by Dan Nixon 6 years ago.: Test file for Fury fit

Change History

comment:1 Changed 6 years ago by Dan Nixon

Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

Description modified (diff)

comment:3 Changed 6 years ago by Dan Nixon

Milestone changed from Backlog to Release 3.3

comment:4 Changed 6 years ago by Dan Nixon

Status changed from assigned to inprogress

Added spin boxes, elwin done, conv and fury work in progress

Refs #10626

Changeset: f43bff351ceec94f75a74a01b8bf9f97dcd461d4

comment:5 Changed 6 years ago by Dan Nixon

Fix new spin boxes for conv fit

Refs #10626

Changeset: 435545077116e17794b7d0f01d085d7ac0f9ee0e

comment:6 Changed 6 years ago by Dan Nixon

Range and preview spectrum selectors on IDA

Refs #10626

Changeset: d4bf294fcb4005adaab04fa7527f3e51a6a04069

comment:7 Changed 6 years ago by Dan Nixon

Add plot legend to IDR Transmission

Refs #10626

Changeset: 144aa63facfdffb3f717b7372762ef9adfa379cd

comment:8 Changed 6 years ago by Dan Nixon

Only change the UI file when needed

Refs #10626

Changeset: d369e10869043ebfec17e7aaa9a5ed94f65ee6e0

comment:9 Changed 6 years ago by Dan Nixon

Merge branch 'master' into feature/10626_better_preview_plots_in_indirect_ui

Refs #10626

Changeset: 4d311681b0651a938825c3c079cad13af9760317

comment:10 Changed 6 years ago by Dan Nixon

Blocked By 10492 added

comment:11 Changed 6 years ago by Dan Nixon

Add plot legends to Indirect Data Analysis

Refs #10626

Changeset: 08e662481977c5b9a7d36882516e791c3a9bb1a6

comment:12 Changed 6 years ago by Dan Nixon

Add validation to single fit options

Refs #10626

Changeset: f34bc8edcd96abcf3fea78bf834a460a0e81c26a

Changed 6 years ago by Dan Nixon

Attachment irs26173_graphite002_elwin_eq2.nxs added

Test file for MSD fit

Changed 6 years ago by Dan Nixon

Attachment irs26176_graphite002_iqt.nxs added

Test file for Fury fit

comment:13 Changed 6 years ago by Dan Nixon

To test:

For each fit interface (MSD, Fury, Conv) in IDA:
- With no file loaded click Fit Single Spectrum, this should give an error (this used to either do nothing or cause a crash)
- Load the sample files
- Switch the preview spectra using the Plot Spectrum spinner, this should be limited to the spectra range
- Change the fit range with the spectra range spinners, they should prevent min > max
- Set the parameters
- Click fit single spectrum, then change the preview spectra range, the fit curve should be removed (or reset for Fury)
- Run
- Verify the fitted range matches the spinners by the output workspace name

Data