Ticket #10648 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

PolarizationCorrection should fetch sensible defaults from a parameter file

Reported by: Harry Jeffery Owned by: Harry Jeffery
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Dan Nixon

Description

If the user does not enter values for Rho, Alpha, Pp, or Ap, PolarizationCorrection should try to use the values specified in the input workspace's instrument's parameter file.

Change History

comment:1 Changed 6 years ago by Harry Jeffery

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Harry Jeffery

  • Status changed from assigned to inprogress

comment:3 Changed 6 years ago by Harry Jeffery

Refs #10648 Fetch polarization parameters from instrument if possible

Changeset: f4b4035de4d7d9ef509336c18e9776ded6789a4c

comment:4 Changed 6 years ago by Harry Jeffery

Testing

  • Open the Polref Refl UI
  • Set the instrument to "POLREF"
  • In the processing table set "Run(s)" to 4699
  • Hit process.
  • It should process successfully
  • Check the history of IvsQ_4699_1
    • The CPp and CRho properties used by PolarizationCorrection should match those found in POLREF_Parameters.xml
Last edited 6 years ago by Harry Jeffery (previous) (diff)

comment:5 Changed 6 years ago by Harry Jeffery

Refs #10648 Fix broken PolarizationCorrection unit test

Changeset: 5eaa685d21b8b42a1bac52c2b8d78db5e11d32b1

comment:6 Changed 6 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:7 Changed 6 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester set to Dan Nixon

comment:8 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10648_polcor_should_fetch_sensible_defaults'

Full changeset: ​777e1e935a3565b78d5b3c09adaba806412b5e90

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11490

Note: See TracTickets for help on using tickets.