Ticket #10656 (closed: fixed)
Feature: Unified color map style for slice viewer and VSI
| Reported by: | Anton Piccardo-Selg | Owned by: | Anton Piccardo-Selg |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.4 |
| Component: | GUI | Keywords: | VATES |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Martyn Gigg |
Description
Currently the VSI and the slice viewer use different default color maps. The default of both should be the same or similar at least. (The slice viewer color map is hardcoded, while VSI loads its definitions from XMl files).
Attachments
Change History
comment:2 Changed 6 years ago by Anton Piccardo-Selg
- Milestone changed from Release 3.3 to Release 3.4
comment:3 Changed 6 years ago by Anton Piccardo-Selg
- Status changed from assigned to inprogress
Refs #10656 Adding user-settable default colormap and background color
Changeset: 0af140a233dea99897041f12e0ef3b3d0e7b8913
comment:4 Changed 6 years ago by Anton Piccardo-Selg
Refs #10656 Store bgnd and cmap settings
Changeset: 1d76022b7cc5e4d67872510f5cbd8308f1dec1d7
comment:5 Changed 6 years ago by Anton Piccardo-Selg
Refs #10656 Add Preference Window tabs
Changeset: f54f44db84f92a3c8f35b9416e1ba6156fa11df9
comment:6 Changed 6 years ago by Anton Piccardo-Selg
Refs #10656 Add common settings for VSI and SV
Changeset: 1aea210742af3a30f1c0adb87e049901ee3c0066
comment:7 Changed 6 years ago by Anton Piccardo-Selg
Refs #10656 Removed test for BackgroundRgbProvider
Changeset: 592f4d9d512720767a753c3aff8b6b49fe92ef5c
comment:8 Changed 6 years ago by Anton Piccardo-Selg
Refs #10656 Migrate initial VSI view to QSettings
Changeset: e2b28cb4aa875440f92e956a7a7da1a204a6e6d3
comment:9 Changed 6 years ago by Anton Piccardo-Selg
Refs #10656 Fix closing window bug and clean up
Changeset: a85e69a92b17f5a510eab87dc841778e4a4c1291
comment:10 Changed 6 years ago by Anton Piccardo-Selg
Refs #10656 Solving merge conflicts
Changeset: 8160a71819f3dc10199b810b83646ae6d8eded4d
comment:11 Changed 6 years ago by Anton Piccardo-Selg
Refs #10656 Fix for color maps
Changeset: c7411c3435cb1353221a7c48a787db2c969fdd45
comment:12 Changed 6 years ago by Anton Piccardo-Selg
Refs #10656 Workaround for bad color maps
Changeset: d02a2320d60d1149db349b484bb68e23ee8761a2
comment:13 Changed 6 years ago by Anton Piccardo-Selg
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #332.
comment:14 Changed 6 years ago by Anton Piccardo-Selg
Refs #10656 Fix header issues for color maps
Changeset: 34ffe45582200ebfe55de588a5c3af5cba394dad
comment:15 Changed 6 years ago by Anton Piccardo-Selg
Refs #10656 Changed the file stream input
Changeset: 41b1e2abcc669691e24f945d92952ae7626c62db
comment:16 Changed 6 years ago by Anton Piccardo-Selg
Refs #10656 Remove warnings through reordering
Changeset: 13132311429cc87d55942798d21cd5a02bbaa95c
comment:17 Changed 6 years ago by Anton Piccardo-Selg
Refs #10656 Fix order in slice viewer
Changeset: ba2ebd97dfeafba70e6cb59f95c9ab291c8ffe7c
comment:18 Changed 6 years ago by Anton Piccardo-Selg
Refs #10656 Fix for reordering
Changeset: 3546c6bddad1755d3e3c19b6668a61c2b628615b
comment:19 Changed 6 years ago by Anton Piccardo-Selg
Refs #10656 Resolved merge conflicts
Changeset: 2f1a2c58e05770ee853e26b19d467ad74606952e
Changed 6 years ago by Anton Piccardo-Selg
- Attachment Test Script for Background Color and Color Map Settings.docx added
comment:20 Changed 6 years ago by Anton Piccardo-Selg
For Testing: Please see the attached document for testing. Please find the sample data sets attached. Please aske me for the MDHisto_Merlin data set, as it is too be to attach. I will pass it on to you.
comment:21 Changed 6 years ago by Anton Piccardo-Selg
Refs #10656 Fix cpp warnings
Changeset: d7de1b6078409c1ab44a7beef85667cfacd3cf5d
comment:22 Changed 6 years ago by Anton Piccardo-Selg
Refs #10656 Reorder in slice viewer
Changeset: 16a6a40a7f28c0c7da47fa76b51745f767abc299
comment:23 Changed 6 years ago by Anton Piccardo-Selg
Jenkins, retest this please
comment:24 Changed 6 years ago by Anton Piccardo-Selg
Jenkins, retest this please
comment:25 Changed 6 years ago by Anton Piccardo-Selg
Jenkins, restest this please
comment:26 Changed 6 years ago by Anton Piccardo-Selg
Refs #10656 Fix osx issue with file streams
Changeset: 1d745a8704a5471730c4b0e5d523f50845d483c8
comment:27 Changed 6 years ago by Anton Piccardo-Selg
Jenkins, retest this please
comment:28 Changed 6 years ago by Anton Piccardo-Selg
Jenkins, retest this please
comment:29 Changed 6 years ago by Anton Piccardo-Selg
Refs #10656 Fix intel compiler warnings
Changeset: dac3eb016a14959233cb2979c780c7da111b6080
comment:30 Changed 6 years ago by Anton Piccardo-Selg
Jenkins, retest this please
comment:31 Changed 6 years ago by Martyn Gigg
It looks like this can no longer be merged cleanly to master. Could you merge master to your branch, please?
comment:32 Changed 6 years ago by Anton Piccardo-Selg
Refs #10656 Resolve merge conflict
Changeset: 55ab31e572ecc5f2e725d6a823bf3fbb694aabb4
comment:33 Changed 6 years ago by Anton Piccardo-Selg
Refs #10656 Get rid of merge issue
Changeset: c6a974eaa988a5a1865544f0fb425f25d8dc6006
comment:34 Changed 6 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:35 Changed 6 years ago by Martyn Gigg
Some nice test instructions here. They seem to have covered all bases.
The functionality seems to make sense as far as I can tell. In future we may want to consider "importing" ParaView's colour map selector widget as we simply have a list of names that don't mean much to users but that is a future improvement.
comment:36 Changed 6 years ago by Martyn Gigg
- Status changed from verifying to closed
Merge pull request #332 from mantidproject/feature/10656_unified_default_color_maps
Unified color maps and settings for Vsi
Full changeset: c969c245974b41d33b326a492ee1811524fab70d
comment:38 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11498
