Ticket #10661 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Extend Instrument repository to remove files

Reported by: Nick Draper Owned by: Nick Draper
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Harry Jeffery

Description

Only ever from the appdataq dir and only when the files are not present on github.

Change History

comment:1 Changed 6 years ago by Nick Draper

re #10661 If file removed from github, remove from appdata instrument

Changeset: d6dae254918b329257d96271bf3262101990442f

comment:2 Changed 6 years ago by Nick Draper

re #10661 remove linux warning

Changeset: d8429274746c13cc7f627caace8e66c3f22cbc05

comment:3 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned
  • Tester set to TSC member

To Test

We don't want to go altering the instrument repository on master, so we will test it by adding an orphaned file instead.

  1. Startup mantidplot
  2. find your appdata instrument directory by running this
    print ConfigService.getInstrumentDirectories()[0];
    
  3. Go to that directory and
    1. Delete github.json if present
    2. Add an empty file "orphaned.xml"
  4. Run the DownloadInstrument alg with the log in debug.
  5. The orphaned.xml should be deleted, with some debug level messages about it.

The bigger question -Resolved see comment 6

Should we do this? The .mantid/instrument directory gives linux users a writable location they can drop edited instrument files and have them used by mantid. This change would delete any local only files on each startup.

Last edited 6 years ago by Nick Draper (previous) (diff)

comment:4 Changed 6 years ago by Nick Draper

  • Status changed from assigned to verify
  • Resolution set to fixed

comment:5 Changed 6 years ago by Nick Draper

re #10661 remove linux warning

Changeset: c8ccb57a436749c72e233bc4ce39bd3ea64dc3fe

comment:6 Changed 6 years ago by Nick Draper

  • Tester TSC member deleted

The bigger question has been resolved in a conversation with Pete Peterson. This directory is not currently used by anyone, and no user knows about it. At the SNS users don't fiddle with instrument files. So this is not an issue.

Free to be tested by anyone.

comment:7 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:8 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10661_support_inst_repo_file_removal'

Full changeset: 118281bc22b0010f59aca5cc9cc114675e87b66a

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11503

Note: See TracTickets for help on using tickets.