Ticket #10705 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Changes to direct Inelastic reduction have inelastic interface broken

Reported by: Alex Buts Owned by: Alex Buts
Priority: critical Milestone: Release 3.3
Component: GUI Keywords:
Cc: Blocked By: #10708
Blocking: #10676 Tester: Lottie Greenwood

Description

Changes #10532 broke inelastic reduction interface

not sure if anybody uses it but as it is there, it should be fixed

Change History

comment:1 Changed 6 years ago by Alex Buts

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Alex Buts

  • Status changed from assigned to inprogress

Re #10705 Spelling errors (just to get started)

Changeset: dd193d4bdbb77a50dc3539c1e4f6a6baeee722de

comment:3 Changed 6 years ago by Alex Buts

  • Blocked By 10708 added

comment:4 Changed 6 years ago by Alex Buts

Re #10705 Spelling errors (just to get started)

Changeset: 8a60a8b92f90e0cd63200615901d8d55ad695b23

comment:5 Changed 6 years ago by Alex Buts

Re #10705 SaveFormats list of formats as css string with formats

Changeset: f119e6a1189b4dfae82c360b67445eef7aaf3a22

comment:6 Changed 6 years ago by Alex Buts

Re #10705 Enabled motors in DirectConvertToEnergy

Still useless but enabled

Changeset: 917989c107c7a13440e5fb04e929181feb1623e4

comment:7 Changed 6 years ago by Alex Buts

Re #10705 Fixed initial run script from GUI

main runner is not yet enabled

Changeset: 7f40b8c737a8d7be1d3671256b5e837c41c9fbec

comment:8 Changed 6 years ago by Alex Buts

Re #10705 Renamed run method from convert_to_energy_transfer to

convert_to_energy (just for consistence)

Changeset: 9269dd95956a52bc2aaed02b231e6e84dcbad5d6

comment:9 Changed 6 years ago by Alex Buts

Re #10705 Added motor and all minor stuff used in GUI but not in scr

Changeset: 181b472d28d0e5d3831b9fd681b31bde168abc81

comment:10 Changed 6 years ago by Alex Buts

Re #10705 Mainly fixed, though some niceness still should be improved

Changeset: 444ee2e63ec763c8f44a9853752eb22d321f1903

comment:11 Changed 6 years ago by Alex Buts

Re #10705 Minor improvements

Changeset: d0735175f709eed69cd22956927a21a54218deda

comment:12 Changed 6 years ago by Alex Buts

Re #10705 Fixing typo (and unit test)

Changeset: 35c255feaa5fe160cc2ae0c8ebe15a22816c75d8

comment:13 Changed 6 years ago by Alex Buts

Re #10705 Should fix system tests

Changeset: a359ef6fec082741db3f1a4d63f04dfd377db555

comment:14 Changed 6 years ago by Alex Buts

Re #10705 Almost all works fine

(may be some odd issue remain) How well this stuff relates to working reduction is still the question.

Changeset: 856f29850f39128c930fcd20079225f6b932220c

comment:15 Changed 6 years ago by Alex Buts

refs #10705 All fixed

Changeset: 0a99b9363c36dd71c007905470cdeb8253fddcf5

comment:16 Changed 6 years ago by Alex Buts

  • Status changed from inprogress to verify
  • Resolution set to fixed

Changes are both in Mantid and System test branches, though system tests are trivial as I've just one method name to simplify and to have common interface.

As interface to reduction has been slightly changed in #10532 and #10708 and Mantid GUI talks to this interface the GUI has been changed slightly. Formally all works, though if the reduction provides correct physical result is another matter. Nobody uses this interface in ISIS anyway, so would wait if anybody tested and requested any changes.

I believe I modified all references to the reduction interface and run it in all possible combinations but tester advised to try more.

A tester of this ticket would also close Release ticket #6414.

Last edited 6 years ago by Alex Buts (previous) (diff)

comment:17 Changed 6 years ago by Alex Buts

Re #10705 Trivial fix to the unit test

Changeset: c3727fb99753d96fe1db433c50bfe8173854a4b1

Last edited 6 years ago by Alex Buts (previous) (diff)

comment:18 Changed 6 years ago by Alex Buts

  • Blocking 10676 added

comment:19 Changed 6 years ago by Lottie Greenwood

  • Status changed from verify to verifying
  • Tester set to Lottie Greenwood

comment:20 Changed 6 years ago by Lottie Greenwood

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/10705_BrokenDirectGUI'

Full changeset: ​e1290e2b90e4a650ae8c8db22303d4090acb8376

comment:21 Changed 6 years ago by Lottie Greenwood

Merge remote-tracking branch 'origin/bugfix/10705_BrokenDirectGUI'

Full changeset: ​b79132cea78461ff6322090b5c7eb642d7088578

comment:22 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11547

Note: See TracTickets for help on using tickets.