Ticket #10706 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

PyLint refactoring (indirect + algorithms)

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description (last modified by Dan Nixon) (diff)

This is an initial attempts at removing the PyLint issues from the indirect inelastic scripts and some of the Python algorithms.

There are some Indirect scripts that have not been touched as they will be removed by tickets that replace them with algorithms (namely anything related to the energy transfer and diffraction reductions).

After the reduction algorithms (#10854 & #10855) have been completed I will likely go over the list of violations again.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned
  • Milestone changed from Backlog to Release 3.4

comment:2 Changed 6 years ago by Dan Nixon

  • Cc borreguero@… added
  • Description modified (diff)

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Started work refactoring indirect Python scripts

Refs #10706

Changeset: 126a19a7e1100410ec0a28b7512216c3b63600a0

comment:4 Changed 6 years ago by Dan Nixon

More refactoring for PyLint in scripts

Refs #10706

Changeset: e307846882ae1e49317b84babf0fea10f88bbef6

comment:5 Changed 6 years ago by Dan Nixon

Refactored SofQWMoments

Refs #10706

Changeset: 945c124dd8865ddf3b3be03ebc2e24347548455d

comment:6 Changed 6 years ago by Dan Nixon

Refactor more indirect related algorithms

Refs #10706

Changeset: bddddc23fe70b8338e17bcf20d376e6ddd626fec

comment:7 Changed 6 years ago by Dan Nixon

Rafactor a couple more Python algorithms

Refs #10706

Changeset: ef306cb747d4434672a25e567786008a5c1f01fd

comment:8 Changed 6 years ago by Dan Nixon

Fix some broken unit tests

Refs #10706

Changeset: 66e14526c1fdbb80ec0a9ef55ef514bf6a1a7e59

comment:9 Changed 6 years ago by Dan Nixon

Refactor more Python algorithms

Refs #10706

Changeset: b030a92c00c874ffb851a4cba94f02f4c75963fe

comment:10 Changed 6 years ago by Dan Nixon

  • Cc borreguero@… removed
  • Component changed from Indirect Inelastic to Framework
  • Description modified (diff)
  • Summary changed from Clean Indirect Python scripts to PyLint refactoring (indirect + algorithms)

I ended up doing more than just the indirect scripts so the goal of this ticket has changed slightly.

comment:11 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #227.

comment:12 Changed 6 years ago by Dan Nixon

Merge branch 'master' into feature/10706_indirect_python_refactor

Conflicts:

Code/Mantid/Framework/PythonInterface/plugins/algorithms/WorkflowAlgorithms/IndirectResolution.py

Refs #10706

Changeset: 19a0db54cae33d8d07764d9a20c2c81e17b8898f

comment:13 Changed 6 years ago by Dan Nixon

  • Description modified (diff)

comment:14 Changed 6 years ago by Dan Nixon

Merge branch 'master' into feature/10706_indirect_python_refactor

Conflicts:

Code/Mantid/Framework/PythonInterface/plugins/algorithms/WorkflowAlgorithms/ResNorm.py Code/Mantid/scripts/Inelastic/IndirectCommon.py Code/Mantid/scripts/Inelastic/IndirectDataAnalysis.py

Refs #10706

Changeset: fed62ed1ffe019cc79204e562de8f46184805467

comment:15 Changed 6 years ago by Dan Nixon

Jenkins, retest this please.

comment:16 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:17 Changed 6 years ago by Martyn Gigg

I've merged the branch to develop so I can check the system tests on Windows.

comment:18 Changed 6 years ago by Martyn Gigg

All of the indirect tests passed, with the exception of the current OSIRIS OS X failure that is a different issue.

comment:19 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge pull request #227 from mantidproject/feature/10706_indirect_python_refactor

Indirect Python refactoring

Full changeset: c4165869c0ee098724bd0e999f5fe6e33b673476

comment:20 Changed 6 years ago by Dan Nixon

This had a very disappointing effect on the number of violations, I think a lot of the fixes must have overlapped with Andrei's.

comment:21 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:22 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11548

Note: See TracTickets for help on using tickets.