Crash when manipulating empty 3D plots

[Federico M Pouzols]

Follow these steps to make Mantid crash badly:

• Create a new matrix (File->New->Matrix) and add some values (1 is enough)

• Create a 3D plot based on the matrix

• Delete the matrix. The plot becomes empty (but the axes are there, as opposed to really empty plots made from an empty matrix, which are just blank).

• If you try to open Format->Plot (or Format->Scales, etc.) for the 3D plot (that is now empty), a pop-up window will tell you: "Not available for empty 3D surface plots!" but then Mantid will crash badly.

[Federico M Pouzols]

Note that if you do not add any value in the matrix, the crash will still happen.

Also, this happens with any of the 3d plots, like 3d wired frame, 3d hidden line, etc.

[Federico Montesino Pouzols]

Prevent crashes using pointer checks and try/catch, re #10713,

Changeset: 80861664c3bc3b023cb1e236a0923605eeee6cc2

[Federico Montesino Pouzols]

be more strict with potential null after dynamic_cast, re #10713,

Changeset: 6ec414ced74a75e2da288ca386a952b917b4d1f9

[Federico M Pouzols]

To test: Check the ticket description and comment #comment:4. Repeat the steps described in the ticket description, or otherwise try to make Mantid crash here.

[Raquel Alvarez Banos]

Merge remote-tracking branch 'origin/bugfix/10713_crash_manipulating_empty_3d_plots'

Full changeset: ​91b4fb1da92c4a171f1fb4a337c0da4b7d9e1bde

[Stuart Campbell]

This ticket has been transferred to github issue ​11555