Ticket #10747 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Remove old Fury code from IndirectDataAnalysis.py and correct system test

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: critical Milestone: Release 3.3
Component: Indirect Inelastic Keywords:
Cc: borreguero@… Blocked By:
Blocking: Tester: Jose Borreguero

Description (last modified by Dan Nixon) (diff)

Left in after this routine was moved to an algorithm.

Also modify the system test to check the new algorithm (Fury) rather than the old code.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Remove old fury code from IDA.py

Refs #10747

Changeset: 0d0c9ec1fd5449fa9a05d5091b9026d6e8671aa9

comment:3 Changed 6 years ago by Dan Nixon

  • Priority changed from major to critical
  • Description modified (diff)
  • Summary changed from Remove old Fury code from IndirectDataAnalysis.py to Remove old Fury code from IndirectDataAnalysis.py and correct system test

comment:4 Changed 6 years ago by Dan Nixon

Updated tests for sequential fits

Refs #10747

Changeset: a4acb89e847079199a0da023b9f1182e447aade9

comment:5 Changed 6 years ago by Dan Nixon

Add correct files for fury dit multi

Refs #10747

Changeset: d6dd06574f63890f546bbf546e85d6bbed3e9754

comment:6 Changed 6 years ago by Dan Nixon

To test:

  • Check all Fury/FuryFit system tests are passing (-R IRISFury will match all 4)
  • Code review, check the fury() and furyPlot() functions in IndirectDataAnalysis.py are not used anywhere

comment:7 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:8 Changed 6 years ago by Jose Borreguero

  • Status changed from verify to verifying
  • Tester set to Jose Borreguero

comment:9 Changed 6 years ago by Jose Borreguero

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10747_remove_old_fury_code'

Full changeset: ​230f53566309e0484f2dc1384b95f0aebae0117c

comment:10 Changed 6 years ago by Jose Borreguero

Merge remote-tracking branch 'origin/feature/10747_remove_old_fury_code'

Full changeset: ​0c12a08f1a1e0ecc219ce1a043e698b74e82a4ca

comment:11 Changed 6 years ago by Jose Borreguero

Works as expected

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11589

Note: See TracTickets for help on using tickets.