Ticket #10753 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Apply absorption corrections algorithm

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.4
Component: Indirect Inelastic Keywords:
Cc: spencer.howells@… Blocked By:
Blocking: Tester: Federico Montesino Pouzols

Description (last modified by Dan Nixon) (diff)

This algorithm will apply absorption corrections calculated with either #10737 or #10738 (or the current Python and Fortran routines).

This should also replace the back end processing on the ApplyCorr tab on Indirect Data Analysis.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress
Last edited 6 years ago by Dan Nixon (previous) (diff)

comment:3 Changed 6 years ago by Dan Nixon

  • Cc spencer.howells@… added

comment:4 Changed 6 years ago by Dan Nixon

Inital commit of apply corr algorithm

Refs #10753

Changeset: 881cf622a1e209c568bc8c9b7c7f317fd50dbaff

comment:5 Changed 6 years ago by Dan Nixon

  • Description modified (diff)

comment:6 Changed 6 years ago by Dan Nixon

Further refactoring of algorithm

Refs #10753

Changeset: 0da4a984e4849ca38c2d176d1473cbfa08949342

comment:7 Changed 6 years ago by Dan Nixon

Merge branch 'master' into 10753_apply_paalman_pings_correction_algo

Refs #10753

Changeset: 96c5442cad60d3afeb60a10749372b55d50f7c6b

comment:8 Changed 6 years ago by Dan Nixon

Work in progress adding corrections for can

Refs #10753

Changeset: 32d5876300b65788ac8be0f0f3b7f7ace812a1d8

comment:9 Changed 6 years ago by Dan Nixon

Add the can scale factor to smaple logs

Refs #10753

Changeset: 3a887d3728e1865e97610151799f7628b69c3690

comment:10 Changed 6 years ago by Dan Nixon

Merge branch 'master' into 10753_apply_paalman_pings_correction_algo

Refs #10753

Changeset: 0f1daa7a19f756c97dd98aab28cead70b9d89a8f

comment:11 Changed 6 years ago by Dan Nixon

Add skeleton docs page and generate unit test data

Refs #10753

Changeset: 3c0d774c0b7c1a60f5f7b578ad58d6764ec5a082

comment:12 Changed 6 years ago by Dan Nixon

Merge branch 'master' into 10753_apply_paalman_pings_correction_algo

Conflicts:

Code/Mantid/Framework/PythonInterface/test/python/plugins/algorithms/CMakeLists.txt

Refs #10753

Changeset: b445bbf40620c2eefb7ff7e839f68d1acdd85db7

comment:13 Changed 6 years ago by Dan Nixon

Added unit test for apply algo

Refs #10753

Changeset: 2e1e6b62521044c849df947b7b653370bc7e4bf1

comment:14 Changed 6 years ago by Dan Nixon

Clean up workspaces correctly

Refs #10753

Changeset: 5742ed37d1e7284316618d0e1ad07150f57e497f

comment:15 Changed 6 years ago by Dan Nixon

Add documentation for apply correction algorithm

Refs #10753

Changeset: e81a29bd6d3aececff4250fa3875329c146275a0

comment:16 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #445.

comment:17 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico Montesino Pouzols

comment:18 Changed 6 years ago by Federico Montesino Pouzols

Well organized, documented an tested. I tried a few variations of the example and it behaved well, including proper error reporting when I misused the algorithm. The output workspaces produced look good as far as I can tell.

comment:19 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from verifying to closed

Merge pull request #445 from mantidproject/10753_apply_paalman_pings_correction_algo

Apply Paalman Pings absorption correction algorithm

Full changeset: ​8ccb3430a011d582185ed51829c1f41858d2e14a

comment:20 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11595

Note: See TracTickets for help on using tickets.