Ticket #10762 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Apply corrections cannot load a corrections workspace

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: critical Milestone: Release 3.3
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Lottie Greenwood

Description (last modified by Dan Nixon) (diff)

Only a file can be loaded, if you try to select a workspace it does not match any of the loaded workspaces, even if you just created one with Calculate Corrections.

Also found that you cannot run Apply cor with no can as the validation did not check to see if the use cna option was actually checked, instead it just assumed it was.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Owner set to Dan Nixon
  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Priority changed from blocker to critical

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Fix apply corr workspace issues

Also correct validation when no can used

Refs #10762

Changeset: 01c1b6d0826fc5ec9fa15d68b7793bbdcc2b24b5

comment:4 Changed 6 years ago by Dan Nixon

  • Description modified (diff)

comment:5 Changed 6 years ago by Dan Nixon

Must be tested on Windows in Release mode.

To test:

  • Create a corrections workspace:
    • Sample: irs26176_graphite002_red.nxs
    • No can
    • Cylinder
    • Radius 1: 0.1
    • Radius 2: 0.2
    • Step: 0.005
    • Beam width: 2.1
    • Sample number density: 0.1
    • Sample formula: H2-O
    • Save disabled
  • Run, should get a workspace group ending in _cyl_abs
  • Go to Apply Corrections
    • Same sample
    • Cylinder
    • Use Corrections
    • Corrections from workspace
    • Workspace from Calc Corr should be in drop down list
    • Run

comment:6 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:7 Changed 6 years ago by Lottie Greenwood

  • Status changed from verify to verifying
  • Tester set to Lottie Greenwood

comment:8 Changed 6 years ago by Lottie Greenwood

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/10762_apply_corrections_use_corrections_workspace'

Full changeset: ​decb245c065e2d08d5d73a2f76bd6a07f0b1e4cd

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11604

Note: See TracTickets for help on using tickets.