Ticket #10766 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Create algorithm to save a tomographic reconstruction parameter file

Reported by: John Hill Owned by: Federico M Pouzols
Priority: major Milestone: Release 3.4
Component: Diffraction Keywords:
Cc: Blocked By: #10889
Blocking: #10564 Tester: Raquel

Description

Create an algorithm which takes an output path and a set of plugin information entries to write to a configuration file for use in a tomographic reconstruction job.

Change History

comment:1 Changed 6 years ago by John Hill

Refs #10766 adding files with first implementation

Changeset: 88023713be27e428f764fcdb05b8bc5856736c93

comment:2 Changed 6 years ago by John Hill

  • Owner changed from John Hill to Federico M Pouzols
  • Status changed from new to assigned
  • Blocking 10564 added

Needs to be checked and updated when the file structure is finalised. Currently accepts a list of Table Workspaces which are written to a nexus file.

Each Table contains a single row with four columns:

• id - unique Plugin ID

• params - json string of name/value pairs for each parameter

• name - user friendly description of the plugin

• cite - citation information about the plugin author

comment:3 Changed 6 years ago by Federico M Pouzols

  • Blocking 10889 added

comment:4 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from assigned to inprogress

updating branch, re #10766

Changeset: 8016c2cf3a4db9e37dabe6dd8f364082807ff892

comment:5 Changed 6 years ago by Federico Montesino Pouzols

clang-format, indentation, copy line, etc. re #10766

Changeset: de8957cf8f6b6912f9f888e7f1a88b0aab75b137

comment:6 Changed 6 years ago by Federico Montesino Pouzols

add SaveTomoConfigTest, re #10766

Changeset: 4d6649b6904e468187178adbf978932fbb0ebdc1

comment:7 Changed 6 years ago by Federico Montesino Pouzols

add starting point for the algorithm doc/doctest, re #10766

Changeset: 1669e4bb2b0dcb5bfd5b7d9351839406a54291b3

comment:8 Changed 6 years ago by Federico Montesino Pouzols

fix includes, re #10766

Changeset: bda3619059773a12e630741cc0d53fefb7f3535f

comment:9 Changed 6 years ago by Federico Montesino Pouzols

fix warnings, and includes and namespaces in test, re #10766

Changeset: 46c6b410ab1e46d128781641e1a3bc5746937e6c

comment:10 Changed 6 years ago by Federico Montesino Pouzols

comment out usage doctest for now, re #10766

Changeset: 85711457c7c8edddd80776a6addf8966971b104c

comment:11 Changed 6 years ago by Federico Montesino Pouzols

fix unreferenced local var warnings on win, re #10766

Changeset: b3ea36eb42ec5e78f8d05000d40050d5c65e194f

comment:12 Changed 6 years ago by Martyn Gigg

There are some documentation warnings on develop - ​http://builds.mantidproject.org/job/develop_clean/610/warnings3Result/

comment:13 Changed 6 years ago by Federico Montesino Pouzols

fill in basic test, comment out usage/doctest for now, re #10766

Changeset: cee4eba69bd416e0e3050f34b7232241c8902fc1

comment:14 Changed 6 years ago by Federico M Pouzols

  • Blocking 10889 removed
  • Blocked By 10889 added

comment:15 Changed 6 years ago by Federico Montesino Pouzols

update algorithm and table/file format, re #10766

Changeset: 36e08400747aa0094fa46b22a055d92d2bced69b

comment:16 Changed 6 years ago by Federico Montesino Pouzols

bring doc and doc-test up to date, re #10766

Changeset: 9eacac7ecf3e1a59b660e2c01473e063ebffcc92

comment:17 Changed 6 years ago by Federico Montesino Pouzols

add more test cases, negative and saveOK, re #10766

Changeset: 4dc76383b097796cebdcc926006fa5b0bbbbd1d5

comment:18 Changed 6 years ago by Federico Montesino Pouzols

files renamed to SaveSavuTomoConfig, re #10766

Changeset: f7002d108d43b011ddf23426a085dd9f499bf5ba

comment:19 Changed 6 years ago by Federico Montesino Pouzols

fixed doc test, also change alg name -> SaveSavuTomoConfig, re #10766

Changeset: 25f5fb0aadd22b2dec5a5f084a1ca89382222e2a

comment:20 Changed 6 years ago by Federico Montesino Pouzols

finalized test/alg, change alg name -> SaveSavuTomoConfig, re #10766

Changeset: 41f0dfac6fddbf4992205dcd6e428e197cb2cfc4

comment:21 Changed 6 years ago by Federico M Pouzols

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #311.

comment:22 Changed 6 years ago by Federico Montesino Pouzols

fixed bug in comparison, re #10766

Changeset: 099adbcf0f97795ccdbf64b02406a7fb9ac5257a

comment:23 Changed 6 years ago by Raquel

  • Status changed from verify to verifying
  • Tester set to Raquel

comment:24 Changed 6 years ago by Raquel

  • Status changed from verifying to closed

Merge pull request #311 from mantidproject/feature/10766_save_tomo_config

Add algorithm SaveSavuTomoConfig (save savu tomography reconstruction pipeline config)

Full changeset: ​cbc7d629645759d68ab6052c90f3384736196fa0

comment:25 Changed 6 years ago by Federico Montesino Pouzols

fix cppCheck warning introduced in a branch just merged in, re #10766

Changeset: 111252b0400ca1a0569a1863fb561de1125b8ffb

comment:26 Changed 6 years ago by Federico Montesino Pouzols

fix cppCheck warning introduced in a branch just merged in, re #10766

Changeset: 111252b0400ca1a0569a1863fb561de1125b8ffb

comment:27 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11608

Note: See TracTickets for help on using tickets.