Ticket #10777 (closed: fixed)
Indirect SofQW does not work properly for some values of Q/E
| Reported by: | Raquel Alvarez Banos | Owned by: | Dan Nixon |
|---|---|---|---|
| Priority: | minor | Milestone: | Release 3.4 |
| Component: | Indirect Inelastic | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Raquel Alvarez Banos |
Description
An unexpected exception is caught for some values of Q in Indirect Data Reduction S(Q,W):
- If Q low > Q High
- If Q width = 0
- If E low > E High
- If E width = 0
- If "e" is entered in any of the above fields
Change History
comment:1 Changed 6 years ago by Dan Nixon
- Status changed from new to assigned
- Owner set to Dan Nixon
comment:2 in reply to: ↑ description Changed 6 years ago by Dan Nixon
- If "e" is entered in any of the above fields
Do you mean when used as, for example, 2e-2? This seems to work fine for me.
comment:3 Changed 6 years ago by Raquel Alvarez Banos
I mean just "e", without the exponent, for instance, "e", "2e", etc
comment:4 Changed 6 years ago by Dan Nixon
- Status changed from assigned to inprogress
Added bin validation, use spin boxes on UI
Refs #10777
Changeset: e3f5e778561159952ba85e8fe9efd09232fab058
comment:5 Changed 6 years ago by Dan Nixon
Corrected property XML, removed unused validation markers
Refs #10777
Changeset: 3ca132489d5520a92d88eb7b9ee0b1975ed70b54
comment:6 Changed 6 years ago by Dan Nixon
To test:
- Open Indirect > Data Reduction > S(Q, w)
- Notice there are now double spinners for binning range
- Load irs26176_graphite002_red.nxs
- Enable rebin in energy
- Set some invalid bin ranges as per description
- Should no longer get an exception but a more useful error message
comment:7 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
comment:8 Changed 6 years ago by Raquel Alvarez Banos
- Status changed from verify to verifying
- Tester set to Raquel Alvarez Banos
comment:9 Changed 6 years ago by Raquel Alvarez Banos
Dan, I'm getting this error:
ERROR: Branch 'feature/10777_indirect_sqw_ui_updates' has not been fully merged to develop, meaning it is not possible to know whether the code is valid on all environments.
It seems that a checkbuild is needed?
comment:10 Changed 6 years ago by Raquel Alvarez Banos
SofQW works fine now: double spinners have been added and useful error messages are shown when invalid ranges are entered.
comment:11 Changed 6 years ago by Raquel Alvarez Banos
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/10777_indirect_sqw_ui_updates'
Full changeset: 03f0e288c6a640e396bf9fa337704a05f8270be5
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11619
