Ticket #10796 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

POLREF: Use stheta to calculate point detector vertical offset

Reported by: Harry Jeffery Owned by: Harry Jeffery
Priority: major Milestone: Release 3.3
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: Tester: Lottie Greenwood

Description

Currently POLREF's IDF tries to use theta to calculate its point detector's vertical offset. POLREF does not write "theta" to its log, but it does write "stheta". Let's use "stheta".

Change History

comment:1 Changed 6 years ago by Harry Jeffery

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Harry Jeffery

  • Status changed from assigned to inprogress

comment:3 Changed 6 years ago by Harry Jeffery

Refs #10796 Use last value of stheta in POLREF

Changeset: 86f5782802c928858844f1f334a227cf8e133eed

comment:4 Changed 6 years ago by Harry Jeffery

Testing

Load POLREF00004699.nxs from systemtests.

Run: 

mtd["POLREF00004699"][0].getInstrument().getComponentByName("point-detector").getPos().Z()

The output should be approximately 0.0222488…

comment:5 Changed 6 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:6 Changed 6 years ago by Lottie Greenwood

  • Status changed from verify to verifying
  • Tester set to Lottie Greenwood

comment:7 Changed 6 years ago by Lottie Greenwood

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10796_use_stheta_in_polref'

Full changeset: ​7256952ee0b77a872e44a19694c5a36a218fda03

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11638

Note: See TracTickets for help on using tickets.