Ticket #10808 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

UserInputValidator should return result of each validation as a boolean

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Harry Jeffery

Description

It would be useful to have the result of each validation step as a bool returned by each call to UserInputValidator::someValidationStep().

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Return bool to indicate result of validation

Also add a function to test for validity across all inputs

Refs #10808

Changeset: 9cf896be39560adc699925a782626f739f860814

comment:3 Changed 6 years ago by Dan Nixon

Added test suite for UserInputValidator

Refs #10808

Changeset: a10fb338b7d53b777a38aed738655431aeeb7667

comment:4 Changed 6 years ago by Dan Nixon

Improve UIV test coverage

Refs #10808

Changeset: 72f4ed3d6fdc7b337b661de8dfe797922f148957

comment:5 Changed 6 years ago by Dan Nixon

To test:

  • Code review
  • Check new unit test passes

comment:6 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:7 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:8 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10808_uiv_return_results_of_each_validation'

Full changeset: ​0410065d7512f8c897746182689d175188418437

comment:9 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11650

Note: See TracTickets for help on using tickets.