Ticket #10811 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Race condition in DownloadInstrumentTest on windows

Reported by: Peter Peterson Owned by: Nick Draper
Priority: critical Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Federico M Pouzols

Description

There appears to be a race condition that only appears on windows in running test_exec and test_execOrphanedFile.

Change History

comment:1 Changed 6 years ago by Nick Draper

re #10811 change file deletion to be specific to avoid race condition

Changeset: 1e411c8d4a1bf8d39eae31d84b257bfc2cb8c8ec

comment:2 Changed 6 years ago by Nick Draper

re #10811 change file to clang format

Changeset: 1f2396a01b7e9984f696639a8f55d0e29b8056d8

comment:3 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

To Test

Check that the unit tests pass.

This is only a change to the unit test, t make the cleanup of files more specific, rather than using wildcards like before.

comment:4 Changed 6 years ago by Nick Draper

  • Status changed from assigned to verify
  • Resolution set to fixed

comment:5 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

comment:6 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to closed

Unit tests pass. Code changes look sensible. In case there would be subtle issues, I run the tests also on Linux (in addition to windows). Everything seems fine.

comment:7 Changed 6 years ago by FedeMPouzols

Merge remote-tracking branch 'origin/feature/10811_downloadinstrumentTest_race_condition'

Full changeset: ​0c2862e6c21470cb84ab0a767927dc72c12aaead

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11653

Note: See TracTickets for help on using tickets.