Ticket #10841 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Bring back the bugfix in direct inelastic occuring when one wants to get event workspace

Reported by: Alex Buts Owned by: Alex Buts
Priority: major Milestone: Release 3.3
Component: Direct Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

This bug (and number of following) has been fixed in develop version of Mantid but may be necessary in Release too.

Change History

comment:1 Changed 6 years ago by Alex Buts

Re #10841 This should fix it

Changeset: d06d899a30612adb8563a366ffce3c3a2e1709f8

comment:2 Changed 6 years ago by Alex Buts

Re #10841 Conflicts with develp

Merge branch 'bugfix/10841_BinningCanBeNone' into develop

Conflicts:

Code/Mantid/scripts/Inelastic/Direct/NonIDF_Properties.py

Changeset: ff44598050f38dbfb0465a6fb570413f6c573817

comment:3 Changed 6 years ago by Alex Buts

  • Status changed from new to assigned

To reproduce this bug one should open ISIS_LETReduction.py from system tests and instead of

      self.iliad_prop.energy_bins = ebinstring;

in Row 144 enter

      self.iliad_prop.energy_bins = None

This should get from reduction an event workspace, converted from energy transfer.

Current version of reduction fails on this assignment.

After the bugfix, the reduction still fails, but usable LET1_spe workspace can be retrieved from Mantid.

The change is needed to work with new normalization framework and normal return from reduction will be fixed in the new reduction.

comment:4 Changed 6 years ago by Alex Buts

  • Status changed from assigned to verify
  • Resolution set to fixed

comment:5 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:6 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/10841_BinningCanBeNone'

Full changeset: 56b4c6d1e9a4a857b956693e374c05e9553297cd

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11683

Note: See TracTickets for help on using tickets.