Ticket #10845 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Enable ExportSampleLogsToCSVFile and ExportExperimentLog to export UTC time

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Dan Nixon

Description

As the request from instrument scientist, ExportSampleLogsToCSVFile and ExportExperimentLog shall export time in UTC time.

Also a note/comment in the exported file should be added to indicate the output time zone.

Change History

comment:1 Changed 6 years ago by Wenduo Zhou

Enabled support for UTC time. Refs #10845."

On branch feature/10845_export_utc

  • modified: Mantid/Framework/PythonInterface/plugins/algorithms/ExportExperimentLog.py
  • modified: Mantid/Framework/PythonInterface/test/python/plugins/algorithms/ExportExperimentLogTest.py

Changeset: a53cc8e381e1a9ac95ddf897c0daf20d093d3455

comment:2 Changed 6 years ago by Wenduo Zhou

Refs #10845. Enabled ExportSampleLogsToCSVFile to support UTC.

Changeset: 7ba247ffaad7446285cf3fab82041bd74b9e0efa

comment:3 Changed 6 years ago by Wenduo Zhou

Cleaned up unit test. Refs #10845."

Changeset: 614fda9ac1b3f2e51b2c976e4cfea85c164cfb45

comment:4 Changed 6 years ago by Wenduo Zhou

Refs #10845. Added time zone info to output datetime.

Changeset: 350a3c4efe1e5b90bf041118817c07c3bc808b27

comment:5 Changed 6 years ago by Wenduo Zhou

  • Status changed from new to assigned

comment:6 Changed 6 years ago by Wenduo Zhou

  • Status changed from assigned to verify
  • Resolution set to fixed

comment:7 Changed 6 years ago by Wenduo Zhou

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:8 Changed 6 years ago by Wenduo Zhou

  • Status changed from reopened to inprogress

Refs #10845. Added more time zones.

And made documentation on the property 'TimeZone'.

On branch feature/10845_export_utc

  • modified: ../Mantid/Framework/PythonInterface/plugins/algorithms/ExportExperimentLog.py
  • modified: ../Mantid/Framework/PythonInterface/plugins/algorithms/ExportSampleLogsToCSVFile.py
  • modified: ../Mantid/docs/source/algorithms/ExportExperimentLog-v1.rst
  • modified: ../Mantid/docs/source/algorithms/ExportSampleLogsToCSVFile-v1.rst

Changeset: d851c7071fab68bfe93e82e70b4616ae4dfb5ef2

comment:9 Changed 6 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed

For tester

A simple way to test this ticket is to look at the usage example of algorithm ExportExperimentLog and ExportSampleLogsToCSVFile. You can set the TimeZone to different time zones such as UTC and America/New York to see the difference in output file.

Also please check the documentation of these two algorithms. The explanation on property 'TimeZone' is made in this ticket.

comment:10 Changed 6 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester set to Dan Nixon

comment:11 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10845_export_utc'

Full changeset: ​bfe3dd5bc0951b08db0aa924f5a24e7aaf4905af

comment:12 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11687

Note: See TracTickets for help on using tickets.