Ticket #10857 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Change SigmaModerator type to Workspace2D for TOFSANSResolutionByPixel

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: critical Milestone: Release 3.3
Component: SANS Keywords:
Cc: richard.heenan@… Blocked By:
Blocking: Tester: Federico M Pouzols

Description

From conversation with Richard betatesting TOFSANSResolutionByPixel.

Change SigmaModerator to be of type Workspace2D where the x-axis is wavelenght (units of AA) and the y-axis is SigmaModerator (units of microseconds).

Use this in calculation of sigma_wavelenght, using linear inteprelation, rather than as this being a constant.

Update documentation of TOFSANSResolutionByPixel.

Attached are RKH files which can be used for testing.

Attachments

resultStddevSANS2d_E2.txt​ (2.0 KB) - added by Anders Markvardsen 6 years ago.
RKH file moderator wavelenght spread for Sans2D

Change History

comment:1 Changed 6 years ago by Anders Markvardsen

  • Status changed from new to assigned

Changed 6 years ago by Anders Markvardsen

RKH file moderator wavelenght spread for Sans2D

comment:2 Changed 6 years ago by Anders Markvardsen

  • Status changed from assigned to inprogress

SigmaModerator can be set by workspace. re #10857

Updated rst doc accordingly

Changeset: 1046c940eb0f9b9ba3613c77395c8497c4c055c1

comment:3 Changed 6 years ago by Anders Markvardsen

  • Status changed from inprogress to verify
  • Cc richard.heenan@… added
  • Resolution set to fixed

To tester:

1) Load e.g. AutoTestData\LOQ48097.raw

2) run ConvertUnits on this dataset to convert from TOF to Wavelength

3) Load the attached file either using LoadRKH or using the Load button

Run TOFSANSResolutionByPixel with InputWorkspace from 2) and SigmaModerator from 3). If it execute then OK.

Optionally read and comment on the updated .rst file.

For information (to Richard mainly) release notes http://www.mantidproject.org/ReleaseNotes_3_3_SANS have been updated accordingly

comment:4 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

comment:5 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to closed

All looks fine. TOFSANSResolutionByPixel runs successfully and fills the y values of the Wavelength-converted workspace with counts (in AA-1). The doc updates read well and tests pass (including TOFSANSResolutionByPixelTest).

comment:6 Changed 6 years ago by Federico Montesino Pouzols

Merge remote-tracking branch 'origin/feature/10857_sigmaModerator'

Full changeset: ​dd971817dcaf94de876644303d0d448d3c8b2cd4

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11699

Note: See TracTickets for help on using tickets.