Ticket #10863 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Qt widget to select an indirect instrument configuration

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.4
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: #10711, #10779, #10960 Tester: Lottie Greenwood

Description (last modified by Dan Nixon) (diff)

This is used on at least three interfaces and the way it is done is slightly different on each one (where it need not be), this should really just be wrapped in a Qt widget that has combo boxed for the instrument, analyser and reflection.

There should be properties for:

  • Technique
  • Removing specific instruments
  • Locking to a single facility
  • Disabling diffraction mode
  • Forcing diffraction mode

It should be laid out as per IDR: Instrument [IRIS v] Analyser [graphite v] Reflection [002 v]

This widget should then be used on IDR, Diffraction and Tools (replace this with a single bar across the top of the window as per IDR).

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Description modified (diff)

comment:3 Changed 6 years ago by Dan Nixon

  • Description modified (diff)

comment:4 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Allow the InstrumentSelector to be locked to a given facility

Added options to load a given facility and disbale reloading on a facility change.

Refs #10863

Changeset: f4fbfd49a5a515c2c44c3844f36b9e06b2ca1366

comment:5 Changed 6 years ago by Dan Nixon

Work in progress adding new widget

Refs #10863

Changeset: 79ecc4e00d0736d971367109e6b926cb108ebb70

comment:6 Changed 6 years ago by Dan Nixon

Work in progress replacing diffraction widget

Refs #10863

Changeset: 15f4f487f1c1327593d1f1c4445053e3e178169c

comment:7 Changed 6 years ago by Dan Nixon

  • Description modified (diff)

comment:8 Changed 6 years ago by Dan Nixon

Removed debugging statement

Refs #10863

Changeset: 18a04d6e3cd2aa85f07c00657645a50ea8a2058d

comment:9 Changed 6 years ago by Dan Nixon

Replaced use of old widgets in diffraction

Refs #10863

Changeset: b3ebfc9a42aa3d06e4d74ee9d726680ebaa50157

comment:10 Changed 6 years ago by Dan Nixon

Fix signal issue, added more docs

Refs #10863

Changeset: f0b357631f67b9ed095e619ce7c6bc190c97b210

comment:11 Changed 6 years ago by Dan Nixon

Replace use in Indirect Data Reduction

Refs #10863

Changeset: ea8523510d19ee26a56dab8554e7785a45fb59b1

comment:12 Changed 6 years ago by Dan Nixon

Correct size policy on IDR

Refs #10863

Changeset: a2edb9a664a6e290c4da7b48171081bfe8a671d2

comment:13 Changed 6 years ago by Dan Nixon

Refactor IDR instrument loading

Refs #10863

Changeset: 08ec6e08760bef11bedaa5e3fa5f69f6bd7001a3

comment:14 Changed 6 years ago by Dan Nixon

Keep last used instrument in IDR

Refs #10863

Changeset: 4de10f9f4920ca8e567b6ba6d08a01773018d249

comment:15 Changed 6 years ago by Dan Nixon

Keep empty inst workspaces out of ADS

Refs #10863

Changeset: 08d05505c7698f8d500618eab30f18141d426c74

comment:16 Changed 6 years ago by Dan Nixon

Replace usage on tools (both load ILL and trans)

Refs #10863

Changeset: 2003afe3a58cd86897a0cf78386d48d0afa4ffb3

comment:17 Changed 6 years ago by Dan Nixon

Support removing instruments and saving/loading IDR inst

Refs #10863

Changeset: 6bbea88a3192441a1cc4fe4d9710d947b3e5b824

comment:18 Changed 6 years ago by Dan Nixon

To test:

  • Test the instrument config options on Indirect Data Reduction, Indirect Diffraction, and Indirect Tools.
  • The last used instrument, analyser and reflection should be saved and reloaded on IDR
  • IDR and Diffraction will show ISIS instruments regardless of facility (ideally these interfaces would properly support other facilities, but for now this at least suppresses vague error messages #9982 #10861)
  • Interfaces no longer crash when you change facility with them open
  • To see instruments on Load ILL, facility must be set to ILL
  • Hidden workspaces are no longer created in ADS for empty instruments (__empty_INST) and calibration range calculations (_tof, _energy)
  • Make sure no instrument selector widgets were broken (AFAIK it's used in the direct, muon, config and first time setup UIs)
Last edited 6 years ago by Dan Nixon (previous) (diff)

comment:19 Changed 6 years ago by Dan Nixon

  • Description modified (diff)

comment:20 Changed 6 years ago by Dan Nixon

Don't allow diffraction with TFXA

Refs #10863

Changeset: e5274a30237a9e238150ea9d15df6ba826eb582b

comment:21 Changed 6 years ago by Dan Nixon

Allow the Instrument label to be hidden

Refs #10863

Changeset: 07fd021d8d0fa7e6d6150c1d64c2f8202fc4f2af

comment:22 Changed 6 years ago by Dan Nixon

  • Blocking 10711 added

(In #10711) This widget fixes issues creating screenshots of tools interface.

comment:23 Changed 6 years ago by Dan Nixon

Keep Calibration range workspaces out of ADS

Refs #10863

Changeset: 1bc314dccd6ec07d6f95b9006c66e43bce6d9afc

comment:24 Changed 6 years ago by Dan Nixon

Keep diffraction instrument workspace out of ADS

Refs #10863

Changeset: 82d2c4b4f53d53475df96a52d4e17185a6f8956b

comment:25 Changed 6 years ago by Dan Nixon

  • Blocking 10779 added

comment:26 Changed 6 years ago by Dan Nixon

Fix boost pointer build error

Refs #10863

Changeset: 3ba65605b48fc5b92069a8cab87bdd777210d109

comment:27 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:28 Changed 6 years ago by Dan Nixon

Fix Doxygen warnings

Refs #10863

Changeset: 40aadeba9e463d309ebe983e6b21c17e719ad345

comment:29 Changed 6 years ago by Dan Nixon

  • Blocking 10960 added

comment:30 Changed 6 years ago by Lottie Greenwood

  • Status changed from verify to verifying
  • Tester set to Lottie Greenwood

comment:31 Changed 6 years ago by Lottie Greenwood

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10863_indirect_instrument_config_widget'

Full changeset: b64ee2c2ddd69e4cb54c361b048fed13b725aec1

comment:32 Changed 6 years ago by Dan Nixon

Merge branch 'feature/10863_indirect_instrument_config_widget' into feature/10960_indirect_ui_size_fix

Refs #10960

Full changeset: b3cb9808dc35759b6535e222a7104d178428a33c

comment:33 Changed 6 years ago by Dan Nixon

Merge branch 'feature/10863_indirect_instrument_config_widget' into feature/10960_indirect_ui_size_fix

Refs #10960

Full changeset: b3cb9808dc35759b6535e222a7104d178428a33c

comment:34 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11705

Note: See TracTickets for help on using tickets.