Ticket #10874 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Absorption corrections uses sample cross sections as can

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: blocker Milestone: Release 3.3
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Federico M Pouzols

Description

The values for can scattering and absorption cross sections are taken from the fields for sample, not can.

Change History

comment:1 Changed 6 years ago by Dan Nixon

Use correct cross sections

Refs #10874

Changeset: 7b44224d335be6baaefb2b84e7a1c351521c5fca

comment:2 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

comment:4 Changed 6 years ago by Dan Nixon

To test:

  • Open Indirect > Data Analysis > Calculate Corrections
  • Input file: /systemtests/Data/irs26176_graphite002_red.nxs
  • Use can: /systemtests/Data/irs26173_graphite002_red.nxs
  • Shape Details
    • Cylinder
    • R1: 0.2
    • R2: 0.25
    • Can Rad: 0.26
    • Step: 0.001
    • Beam: 2.1
  • Sample Details
    • Density: 0.1
    • Scatering cross-section: 56.0907
    • Absorption cross-seciton: 0.221797
  • Can Details
    • Density: 0.1
    • Scatering cross-section: 5.1
    • Absorption cross-seciton: 5.08
  • Run

Should see the following lines towards the start of the log output: 

Sam : sigt = 56.0907 ; siga = 0.221797 ; rho = 0.1
Can : sigt = 5.1 ; siga = 5.08 ; rho = 0.1

Without this fix the values for sigt and siga are the same for sample and can (both taking the value set for the sample).

Last edited 6 years ago by Dan Nixon (previous) (diff)

comment:5 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:6 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

comment:7 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to closed

It seems to work. Code changes look sensible and safe enough. Tested on windows 7 (on other platforms you'll get an "F2Py functionality not currently available for your platform").

comment:8 Changed 6 years ago by Federico Montesino Pouzols

Merge remote-tracking branch 'origin/feature/10874_abs_corr_use_correct_cross_sections'

Full changeset: ​3a1d375814317d8539b79300f7c39453a7d01843

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11713

Note: See TracTickets for help on using tickets.