Ticket #10886 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

PlotAsymmetryByLogValue fails to load deadtimes from specified file

Reported by: Raquel Alvarez Banos Owned by: Raquel Alvarez Banos
Priority: major Milestone: Release 3.4
Component: Muon Keywords:
Cc: Blocked By:
Blocking: Tester: Dan Nixon

Description

PlotAsymmetryByLogValue gives the option to apply dead time corrections from specified file. However, when this option is selected, the algorithm throws an exception, as you are not given the possibility to select any files. "FromSpecifiedFile" should behave as "FromRunData" and show a file widget when it is selected.

Attachments

dead_times_processed.nxs (14.2 KB) - added by Raquel Alvarez Banos 6 years ago.

Change History

comment:1 Changed 6 years ago by Raquel Alvarez Banos

  • Blocked By 10894 added

comment:2 Changed 6 years ago by Raquel Alvarez Banos

Actually, "FromRunData" does not need show any file widget, as dead-time corrections are loaded from the input run files. The two options are swapped: "FromRunData" should not have any widget associated while "FromSpecifiedFile" should.

comment:3 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from new to assigned
  • Blocked By 10894 removed

comment:4 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from assigned to inprogress

comment:5 Changed 6 years ago by Raquel Alvarez Banos

Re #10886 Changing index in dead time type

Changeset: 9172dea512f7244d545573b37552efbff7f04bdf

comment:6 Changed 6 years ago by Raquel Alvarez Banos

Re #10886 Recover lost change in dead time type

Changeset: 605309210a73e32affc300ee4fcc88ea1e52e2c3

Changed 6 years ago by Raquel Alvarez Banos

comment:7 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from inprogress to verify
  • Resolution set to fixed

For tester: check that the options "None", "FromRunData" and "FromSpecifiedFile" behave as expected (see comment 2). "dead_time_processed.nxs" attached can be used as an input example for option "FromSpecifiedFile".

comment:8 Changed 6 years ago by Nick Draper

Another one with code not merged to develop, please open a pull request for this.

comment:9 Changed 6 years ago by Raquel

This is being verified as pull request #229.

comment:10 Changed 6 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester set to Dan Nixon

comment:11 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge pull request #229 from mantidproject/bugfix/10886_PlotAsymmetryByLogValue_fails_to_load_from_specified_file

Fix PlotAsymmetryByLogValue when dead times are loaded from file

Full changeset: 2b7694068eb9ad39c89b68185be2938439ffc325

comment:12 Changed 5 years ago by Nick Draper

  • Component changed from Framework to Muon

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11725

Note: See TracTickets for help on using tickets.