Ticket #10888 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

State of "Show Whitespace" option in Script Window incorrect

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: critical Milestone: Release 3.3
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Federico M Pouzols

Description

This only happens when loading via the File->Load option

To reproduce:

  • clear ScriptWindow config from QSettings;
  • click "File->Load->File";
  • select a python script;
  • the script window is opened with the file contents and whitespace visible but clicking the Window menu shows that it should be disabled.

As this was a new feature for 3.3 it would be good to ship it for the first time in a reasonable state.

Change History

comment:1 Changed 6 years ago by Martyn Gigg

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Martyn Gigg

  • Status changed from assigned to inprogress

Fix initial state of 'Show Whitespace' option in script window.

Refs #10888

Changeset: 693df1a00f5e4d8397c25541902c7fa852a3958c

comment:3 Changed 6 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #122.

comment:4 Changed 6 years ago by Martyn Gigg

retest this please

comment:5 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

comment:6 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to closed

Merge pull request #122 from mantidproject/bugfix/10888_show_whitespace_state

Works well, the visibility is in sync with the "Window->Show Whitespace" option.

Full changeset: ​c0f1bcf83861262d7d6fb981398ca9118682d8c9

comment:7 Changed 6 years ago by Federico M Pouzols

  • Status changed from closed to verifying

comment:8 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to closed

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11727

Note: See TracTickets for help on using tickets.