Ticket #10889 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Create LoadSavuTomoConfig algorithm to load a tomographic reconstruction parameter file

Reported by: Federico M Pouzols Owned by: Federico M Pouzols
Priority: major Milestone: Release 3.4
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: #10564, #10766, #11180 Tester: Raquel

Description (last modified by Federico M Pouzols) (diff)

This is a sibling of #10766.

In principle the algorithm will load a tomographic reconstruction parameter file (hdf format) into a table workspace. See #10766 for details on the contents of the table.

This algorithm should come with a test, which can be based on an example parameter file to kick this off. This algorithm is actually required to finish #10766, as the test of SaveTomoConfig should try to Save and then Load.

Note: LoadTomoConfig -> renamed to LoadSavuTomoConfig to be more specific. SaveTomoConfig (#10766) will be SaveSavuTomoConfig.

Change History

comment:1 Changed 6 years ago by Federico M Pouzols

  • Blocking 10564 added

comment:1 Changed 6 years ago by Federico M Pouzols

  • Status changed from new to assigned
  • Blocking 10564 removed
  • Description modified (diff)

comment:2 Changed 6 years ago by Federico M Pouzols

  • Blocking 10564 added

comment:4 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from assigned to inprogress

added algorithm, test, and doc/doctest files, re #10889

Changeset: e13fbe975be18a1af8aa1fc1e55d2063abd0cd87

comment:5 Changed 6 years ago by Federico Montesino Pouzols

fix basic alg description, re #10889

Changeset: aba8c5f723f3ba0160f039874960b6db5165690e

comment:6 Changed 6 years ago by Federico Montesino Pouzols

Fill in alg code and doc/test, still TODOs for open issues, re #10889

Changeset: 157c60c434d74893130ea881dd1c4b900fd99440

comment:7 Changed 6 years ago by Federico Montesino Pouzols

some comments to clarify the still unfinished format, re #10889

Changeset: dc6fefa52472db2c4e27a168b0bab33dee2f9f10

comment:8 Changed 6 years ago by Federico Montesino Pouzols

use algorithm factory in test, re #10889

Changeset: 6a66f59ac140ab9f638de174a3f8aee723ac75ea

comment:9 Changed 6 years ago by Federico Montesino Pouzols

update algorithm for current savu examples/tests, re #10889

Changeset: df592ac0f2e180f59d3c2fc572390d6f4c89139e

comment:10 Changed 6 years ago by Federico Montesino Pouzols

unit and doc tests now decently complete, re #10889

Changeset: ce46c1f8127fa5dc889954eb5918c7fb2a1696ac

comment:11 Changed 6 years ago by Federico Montesino Pouzols

added unit test data example, re #10889

Changeset: a01b45d697cb154920bf7547ad85cdaea6acde89

comment:12 Changed 6 years ago by Federico Montesino Pouzols

final touch to the unit test, for now, re #10889

Changeset: 155cbe36bd273c450111aa62b7e3a88856f438c2

comment:13 Changed 6 years ago by Federico Montesino Pouzols

Algorithm renamedL LoadTomoConfig -> LoadSavuTomoConfig, re #10889

Changeset: 0054d626fddc37e710d0334aa973effd7805a52f

comment:14 Changed 6 years ago by Federico Montesino Pouzols

doc test fixes (output format and new alg name), re #10889

Changeset: 9a0b2ae5fa3957e9317bd7e0a8689f526b20dc96

comment:15 Changed 6 years ago by Federico Montesino Pouzols

update code for new alg name, re #10889

Changeset: dfd3be1aa146c7763b9ff3bcb4d3039e634b15bf

comment:16 Changed 6 years ago by Federico M Pouzols

  • Description modified (diff)
  • Summary changed from Create LoadTomoConfig algorithm to load a tomographic reconstruction parameter file to Create LoadSavuTomoConfig algorithm to load a tomographic reconstruction parameter file

comment:17 Changed 6 years ago by Federico M Pouzols

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #286.

comment:18 Changed 6 years ago by Federico M Pouzols

  • Blocking 10766 added
  • Blocked By 10766 removed

comment:19 Changed 6 years ago by Federico Montesino Pouzols

fix ambiguity template-parameter vs namespace, re #10889

Changeset: 0839053a008851bc23b630fc1e306fcd38a6e4be

comment:20 Changed 6 years ago by Federico Montesino Pouzols

fix for shared_ptr constructor, re #10889

Changeset: 62ddae7f5fb63ff649b44766427f26ae5fd4e27a

comment:21 Changed 6 years ago by Federico M Pouzols

Jenkins retest this please

comment:22 Changed 6 years ago by Federico M Pouzols

Jenkins retest this please

comment:23 Changed 6 years ago by Federico Montesino Pouzols

changed category in sync with upcoming Save, re #10889

Changeset: 52ef431a6e03c0a514f8b680ac2fce2658ea49c6

comment:24 Changed 6 years ago by Federico Montesino Pouzols

better column names and doc, re #10889

Changeset: dbbd63c6230658551a6f6787fbc0156e628bdaa4

comment:25 Changed 6 years ago by Federico Montesino Pouzols

update params column name, re #10889

Changeset: 75843b507336307bb73e24d7323194a5ff71f506

comment:26 Changed 6 years ago by Federico Montesino Pouzols

add testcleanup block, re #10889

Changeset: 7dfc79ddc6e31065a475201ee03fe9c6feb00a5b

comment:27 Changed 6 years ago by Federico Montesino Pouzols

fix typo in docs test, re #10889

Changeset: 657afac559b84064ec560c4f322bbac9ed69b3a6

comment:28 Changed 6 years ago by Federico Montesino Pouzols

add ifdef exception for osx 10.8 - nexus bug, re #10889

Changeset: 74d1acdb78753b425c99cef3c485c6afcaeead23

comment:29 Changed 6 years ago by Federico M Pouzols

Jenkins retest this please

comment:30 Changed 6 years ago by Federico M Pouzols

Jenkins, retest this please

comment:31 Changed 6 years ago by Federico M Pouzols

Jenkins, retest this please.

comment:32 Changed 6 years ago by Federico Montesino Pouzols

fix expected strings for osx 10.8 re #10889

Changeset: 9f2eb1ca28142de30f3f9f87c17d9b80fadcb30b

comment:33 Changed 6 years ago by Federico M Pouzols

Jenkins, retest this please.

comment:34 Changed 6 years ago by Federico M Pouzols

Jenkins, could you retest this please?

comment:35 Changed 6 years ago by Federico M Pouzols

Jenkins, could you test this please?

comment:36 Changed 6 years ago by Federico M Pouzols

  • Blocking 11180 added

comment:37 Changed 6 years ago by Federico M Pouzols

Jenkins, retest this please

comment:38 Changed 6 years ago by Federico M Pouzols

Jenkins, retest this please

comment:39 Changed 6 years ago by Federico M Pouzols

Jenkins, retest this please

comment:40 Changed 6 years ago by Federico M Pouzols

Jenkins, retest this please

comment:41 Changed 6 years ago by Federico M Pouzols

Jenkins, retest this please.

comment:42 Changed 6 years ago by Raquel

  • Status changed from verify to verifying
  • Tester set to Raquel

comment:43 Changed 6 years ago by Federico Montesino Pouzols

fix typos pointed out by tester, re #10889

Changeset: b94e8974e150733045e08d8f7937e6dd6d835167

comment:44 Changed 6 years ago by Raquel

Works as expected. Code, unit tests and user example well documented. Still some TODOs that will be addressed in future work.

comment:45 Changed 6 years ago by Raquel

  • Status changed from verifying to closed

Merge pull request #286 from mantidproject/feature/10889_create_LoadTomoConfig_alg

New LoadSavuTomoConfig algorithm

Full changeset: ​35b686b709f597b5d6b11dec77744ce903c9a085

comment:46 Changed 6 years ago by Federico Montesino Pouzols

verbatim for xml in doxygen blocks, the warning comes from re #10889

Changeset: e6782c5087cabb071aea508e9fec76d90d961ab5

comment:47 Changed 6 years ago by Federico Montesino Pouzols

verbatim for xml in doxygen blocks, the warning comes from re #10889

Changeset: 3ce0fbaf0134fab598d656297311f8ad84b17855

comment:48 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11728

Note: See TracTickets for help on using tickets.