Ticket #10903 (closed: fixed)
IDA: new abs. corrections tab
| Reported by: | Dan Nixon | Owned by: | Dan Nixon |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.4 |
| Component: | Indirect Inelastic | Keywords: | |
| Cc: | spencer.howells@… | Blocked By: | #10897 |
| Blocking: | Tester: | Federico Montesino Pouzols |
Description
After #10897 there will be cross platform way of doing absorption corrections for indirect data, there should be an additional tab for this.
This will be an additional tab so that Windows (and advanced Linux) users can still run the Fortran corrections which do proper can corrections.
Change History
comment:1 Changed 6 years ago by Dan Nixon
- Status changed from new to assigned
- Blocked By 10897 added
comment:2 Changed 6 years ago by Dan Nixon
- Status changed from assigned to inprogress
Added initial files for new abs corr tab
Refs #10903
Changeset: 3257e8a61fc234894da1c61f89c99aa735ada30f
comment:4 Changed 6 years ago by Dan Nixon
Refactoring and add remaining UI options
Refs #10903
Changeset: 374617a00b4e5b3061cb10fe116b5c33e32c106d
comment:5 Changed 6 years ago by Dan Nixon
Add remaining options for can corrections
Refs #10903
Changeset: c747647dfc2ae135a1fc2cca707ed1d0b0c7706f
comment:6 Changed 6 years ago by Dan Nixon
Call the correction algorithms from the UI
Refs #10903
Changeset: 96dceb16a608fa539c613a1ea1e6f115509de424
comment:7 Changed 6 years ago by Dan Nixon
Add default parameters to validation indicators
Refs #10903
Changeset: 46b07f6021dda405f772e60ff8e2dcd4250d538c
comment:8 Changed 6 years ago by Dan Nixon
Add validation for data andchemical formulas
Refs #10903
Changeset: 7fc87c248fac02af1e9ed2fc615bfde6309b0ebe
comment:10 Changed 6 years ago by Dan Nixon
comment:11 Changed 6 years ago by Dan Nixon
Merge branch 'master' into 10903_ida_abs_corr_tab
Refs #10903
Changeset: 15e442dd88301b8bed392876c74b2fd08c460b7c
comment:12 Changed 6 years ago by Dan Nixon
Added wavelength validation, tify UI
Refs #10903
Changeset: fa11f69696363dcf469c4def7d68c8dfb7bfaf2a
comment:13 Changed 6 years ago by Dan Nixon
comment:14 Changed 6 years ago by Dan Nixon
Add saving, include shape in ws name
Refs #10903
Changeset: e9e9781b8ffeec413607dc894e62d08b8dd1a22a
comment:15 Changed 6 years ago by Dan Nixon
Correct tab stops Refs #10903
Changeset: ded9b4b9ac6c08e7edaa3d9627e5672de7bfd55b
comment:16 Changed 6 years ago by Dan Nixon
comment:17 Changed 6 years ago by Dan Nixon
comment:18 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #476.
comment:19 Changed 6 years ago by Dan Nixon
Merge branch 'master' into 10903_ida_abs_corr_tab
Refs #10903
[ci skip]
Changeset: 2c003ffaf8fe7883fea35069927de3621da4885c
comment:20 Changed 6 years ago by Dan Nixon
comment:21 Changed 6 years ago by Dan Nixon
Merge branch 'master' into 10903_ida_abs_corr_tab
Refs #10903
Changeset: fa0f0a170f6753f09296f2238d755a8028d6487a
comment:22 Changed 6 years ago by Federico Montesino Pouzols
- Status changed from verify to verifying
- Tester set to Federico Montesino Pouzols
comment:23 Changed 6 years ago by Federico Montesino Pouzols
All looks good to me. The documentation is clear and goes to the point. I'd perfectly know how to use this interface even though I have no clue of the theory and calculations behind. I tried the 3 geometries and it seems to be lousy-user-proof. Strange values (0, etc.) are handled with informative errrors.
Maybe the only detail that was not obvious/explicit to me at first is that when you enable 'Save Result' the files are named exactly as the workspaces, simply appending .nxs, like irs26176_graphite002_FlatPlate_Corrected.nxs. There could be a note about this in the description of "Save Result", but that can always be added later.
comment:24 Changed 6 years ago by Federico Montesino Pouzols
- Status changed from verifying to closed
Merge pull request #476 from mantidproject/10903_ida_abs_corr_tab
IDA Absorption Corrections tab
Full changeset: 5f40c07a58463ecac402aa4d55de565eee747882
comment:25 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11742
