Ticket #10908 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

SplineInterpolation fails when not outputting the derivative WS

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Harry Jeffery

Description

The code that sets this output property assumes that if the derivative order is greater than zero then you must want the output, since the default value of DerivOrder is 2 this causes the algorithm to fail when all you want is the interpolated workspace.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Summary changed from SplineInterpolation fails when not outputting ther derivative WS to SplineInterpolation fails when not outputting the derivative WS

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Add check to see if WS name is set

Refs #10908

Changeset: 5ecba3847e3fde3220de9a1fa948bea1cc4ae41f

comment:4 Changed 6 years ago by Dan Nixon

To test:

  • Create/load some workspaces (see SplineInterpolate usage examples)
  • Run in following configurations:
    • DerivOrder=2, OutputWorkspaceDeriv=""
    • DerivOrder=0, OutputWorkspaceDeriv="deriv"
    • DerivOrder=2, OutputWorkspaceDeriv="deriv"
  • All should execute successfully, only last should output a derivative workspace

Without the fix the first configuration would fail.

comment:5 Changed 6 years ago by Dan Nixon

Giv annon name for deriv WS in tests

Refs #10908

Changeset: d8c786a900253db045e58a2f918e356043199ec6

comment:6 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:7 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:8 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/10908_splineinterpolate_fails_with_no_deriv_ws'

Full changeset: ​6582799d41a253b08270bea3e51a16fbc0f7f5d5

comment:9 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11747

Note: See TracTickets for help on using tickets.