Ticket #10923 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Fix UserInputValidator tests

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: critical Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Federico M Pouzols

Description (last modified by Dan Nixon) (diff)

Currently the tests for UserInputValidator do not compile as UIV needs the DLLExport added to it.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Description modified (diff)

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Add DLLExport to UserInputValidator

Refs #10923

Changeset: dc65371ae9ca2a3b7869488f13f955e2785918fb

comment:4 Changed 6 years ago by Dan Nixon

To test:

  • Verify Windows build is passing

comment:5 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:6 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

comment:7 Changed 6 years ago by Federico M Pouzols

Everything seems fine, and it's building well locally. builds.mantidproject.org is currently irresponsive. I'll double-check once it's back and I'll pass this ticket.

comment:8 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to closed

comment:9 Changed 6 years ago by Federico Montesino Pouzols

Merge remote-tracking branch 'origin/bugfix/10923_fix_uiv_tests'

Full changeset: ​fd1b168d04319a2e162d2dfac0193ab5c89ce15a

comment:10 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11762

Note: See TracTickets for help on using tickets.