Ticket #10929 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Implement an algorithm to reduce HB2A's data

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: petersonpf@…, saviciat@… Blocked By:
Blocking: Tester: Andrei Savici

Description (last modified by Wenduo Zhou) (diff)

Implement an algorithm to reduce HB2A's data. The inputs will be 2 well defined MDWorkspaces for experiment data and monitor counts. The reduction should rebin and normalize the counts on detectors to a 1 spectrum MatrixWorkspace.

A virtual instrument will be created to reflect the combination of moving detectors. Complete sets of log samples will be generated for reference.

Attachments

verify10929A.py (926 bytes) - added by Wenduo Zhou 6 years ago.
verify10929B.py (2.0 KB) - added by Wenduo Zhou 6 years ago.
HB2A_exp0231_scan0001.dat (47.5 KB) - added by Wenduo Zhou 6 years ago.
HB2A_exp0231_scan0002.dat (19.0 KB) - added by Wenduo Zhou 6 years ago.
HB2A_exp0231_scan0003.dat (47.5 KB) - added by Wenduo Zhou 6 years ago.

Change History

comment:1 Changed 6 years ago by Wenduo Zhou

Refs #10929. Started the project.

By adding .h, .cpp, Test.h and .rst file. And modified CMakeLists.

  • modified: MDAlgorithms/CMakeLists.txt
  • new file: MDAlgorithms/inc/MantidMDAlgorithms/ConvertCWPDMDToSpectra.h
  • new file: MDAlgorithms/src/ConvertCWPDMDToSpectra.cpp
  • new file: MDAlgorithms/test/ConvertCWPDMDToSpectraTest.h
  • new file: ../docs/source/algorithms/ConvertCWPDMDToSpectra-v1.rst

Changeset: bebda25fe713697127532d9589970dfe5111d886

comment:2 Changed 6 years ago by Wenduo Zhou

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Wenduo Zhou

  • Status changed from assigned to inprogress

comment:4 Changed 6 years ago by Wenduo Zhou

  • Cc saviciat@… added
  • Description modified (diff)

comment:5 Changed 6 years ago by Wenduo Zhou

  • Blocked By 10622 removed

comment:6 Changed 6 years ago by Wenduo Zhou

Refs #10929. Checkpointing implementing algorithm and unit test.

Changeset: 6ff568087bc21880bfdec3a1547aaa2ab98aee3c

comment:7 Changed 6 years ago by Wenduo Zhou

Refs #10929. Wrote docs and implemented error calculation.

Changeset: 18af96f042d301e6e92ca5940af4fa025276356c

comment:8 Changed 6 years ago by Wenduo Zhou

Refs #10929. Implemented linear interpolation and unit conerter.

Changeset: 7391d73cd0681aab9d6728b42fa165438dd021d9

comment:9 Changed 6 years ago by Wenduo Zhou

Cleaned the codes. Refs #10929.

Changeset: 49caa2806d9c22e4ba6a8ade3b001366c573c674

comment:10 Changed 6 years ago by Wenduo Zhou

Refs #10929. Fixed an issue in ConvertSpiceDataToRealSpace.

  • modified: ../Mantid/Framework/MDAlgorithms/src/ConvertCWPDMDToSpectra.cpp : tried fix some problem of linear interpolation (not finished yet)
  • modified: ../Mantid/Framework/MDAlgorithms/src/ConvertSpiceDataToRealSpace.cpp : fixed an issue as no run start is given

Changeset: 00ec1da72cc50c6c6ee6c5feea603b3bf807cbdb

comment:11 Changed 6 years ago by Wenduo Zhou

Refs #10929. Fixed issues with unit tests.

Changeset: 97fec298f65c4aa3d0bcc7a5d0a806a3fc8b1e4d

comment:12 Changed 6 years ago by Wenduo Zhou

Refs #10929. Checkpointing minor corrections.

Changeset: 68526f9575d0e0b7991af3a497be55a80a6d901f

comment:13 Changed 6 years ago by Wenduo Zhou

Started to refactor the unit conversion path. Refs #10929.

Changeset: a6ab212a01fac50ed704e1528b1666e6536a6f94

comment:14 Changed 6 years ago by Wenduo Zhou

Refs #10929. Made change on how to handle output unit.

Changeset: d5297015181ea54d06e3bf4a8b177ebdb6435067

comment:15 Changed 6 years ago by Wenduo Zhou

Refs #10929. Fixed a bug for unit Q.

Changeset: 9a6efbd0699d3578d82cb0bef87a6c420a137073

comment:16 Changed 6 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #285.

comment:17 Changed 6 years ago by Wenduo Zhou

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:18 Changed 6 years ago by Wenduo Zhou

  • Status changed from reopened to inprogress

Refs #10929. Made some improvements.

  1. Fix the label for Y value: Intensity
  2. Fix the doxygen warning
  3. Fix cppcheck
  4. Fixes the standard error issue in ConvertSpiceToRealSpace
  5. Add 'start_time' to LoadSpiceAscii, ConvertSpiceToRealSpace and ConvertCWPDMDToSpectra

Changeset: e8c1fc344f80eacde88336f4a01700adb592011c

comment:19 Changed 6 years ago by Martyn Gigg

Please can you give a better title to the pull request. It shouldn't have the ticket reference in it and should be a short sentence describing the changes - something like "New algorithm to convert reactor-based powder data to spectrum matrix" would be fine.

comment:20 Changed 6 years ago by Wenduo Zhou

Fixes issue with sample logs. Refs #10929.

Changeset: 457e160f228973ea03600926a168c04106437cc4

comment:21 Changed 6 years ago by Wenduo Zhou

Trivial change after merging master. Refs #10929.

Changeset: 40107ec02ad6eef976906880f2a4430144554b08

comment:22 Changed 6 years ago by Wenduo Zhou

Removed log start_time. Refs #10929.

Changeset: 739f1746aab0172fd172eb5e7f6a5025b8f97212

comment:23 Changed 6 years ago by Wenduo Zhou

Fixed doc test and cleaned output. Refs #10929.

Changeset: c87c044453d9a7a2ad0d8297815e677a3cfd1488

comment:24 Changed 6 years ago by Wenduo Zhou

Fixed a windows warning. Refs #10929.

Changeset: e1b896c56e966accebe45b13e96a47ef019222a5

comment:25 Changed 6 years ago by Wenduo Zhou

Refs #10929. Fixed some minor issues.

Changeset: 405723b5c7870002da9cf0b0a0500aa61a5c723c

comment:26 Changed 6 years ago by Wenduo Zhou

Expanding unit test. Refs #10929.

Changeset: 0071789402950fa1c1c4f64bf4ce909124920833

comment:27 Changed 6 years ago by Wenduo Zhou

Fixed an issue of error propagating. Refs #10929.

Changeset: 4518f99b320d24ed13f6dc86d4e521f19af47500

comment:28 Changed 6 years ago by Wenduo Zhou

Refs #10929. Improved documentation.

Changeset: 0caab9c89ec2ff92480cedc9557119b64dc930f4

comment:29 Changed 6 years ago by Wenduo Zhou

Fixed some minor issues on doc. Refs #10929.

Changeset: 32877bee83a166202113ea6d27bccf33eecba73b

Changed 6 years ago by Wenduo Zhou

Changed 6 years ago by Wenduo Zhou

Changed 6 years ago by Wenduo Zhou

Changed 6 years ago by Wenduo Zhou

Changed 6 years ago by Wenduo Zhou

comment:30 Changed 6 years ago by Wenduo Zhou

For tester

The files for verifying this pull request can be found at https://gist.github.com/wdzhou/0bccce66d7c322153e54

comment:31 Changed 6 years ago by Andrei Savici

  • Status changed from inprogress to verifying
  • Tester set to Andrei Savici

comment:32 Changed 6 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge pull request #285 from mantidproject/feature/10929_reduce_hb2a

New algorithm to bin HFIR powder diffractometer data from MDEventWorkspaces

Full changeset: a8ad2e4aa3704b03f85aa06c050793c1a1107028

comment:33 Changed 5 years ago by Nick Draper

  • Resolution set to fixed

Somehow these slipped through without a resolution. Set to Fixed.

comment:34 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11768

Note: See TracTickets for help on using tickets.