Ticket #10934 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Fix to CutMD

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: critical Milestone: Release 3.4
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: #10693 Tester: Ian Bush

Description

CutMD not working with step size specified in 4 dimensions.

This works, 

to_cut = CreateMDWorkspace(Dimensions=4, Extents=[-1,1,-1,1,-1,1,-10,10], Names='H,K,L,E', Units='U,U,U,V')
SetUB(Workspace=to_cut, a = 1, b = 1, c = 1, alpha =90, beta=90, gamma = 90)
SetSpecialCoordinates(InputWorkspace=to_cut, SpecialCoordinates='HKL')
out_md = CutMD(to_cut, P1Bin=[-0.5,0.5], P2Bin=[-0.1,0.1], P3Bin=[-0.3,0.3], P4Bin=[-8,8],  NoPix=True)

But this doesn't 

to_cut = CreateMDWorkspace(Dimensions=4, Extents=[-1,1,-1,1,-1,1,-10,10], Names='H,K,L,E', Units='U,U,U,V')
SetUB(Workspace=to_cut, a = 1, b = 1, c = 1, alpha =90, beta=90, gamma = 90)
SetSpecialCoordinates(InputWorkspace=to_cut, SpecialCoordinates='HKL')
out_md = CutMD(to_cut, P1Bin=[-0.5,0.5], P2Bin=[-0.1,0.1], P3Bin=[-0.3,0.3], P4Bin=[-8,1,8],  NoPix=True)

Change History

comment:1 Changed 6 years ago by Owen Arnold

refs #10934. Fix 4d problem.

Changeset: c72fe8adaa7304fc3c77750aaef38e44cf85bb77

comment:2 Changed 6 years ago by Owen Arnold

  • Status changed from new to verify
  • Resolution set to fixed

This is being verified as ​pull request #135.

comment:3 Changed 6 years ago by Martyn Gigg

Could you provide a link to the ticket (in this and other pull requests) in the original description along the same lines as is done here: ​https://github.com/mantidproject/mantid/pull/130?

comment:4 Changed 6 years ago by Ian Bush

  • Status changed from verify to verifying
  • Tester set to Ian Bush

comment:5 Changed 6 years ago by ianbush

Merge pull request #135 from mantidproject/feature/10934_cut_md_fix

refs #10934. Fix 4d problem.

Changeset: 51986bc0489c50c4a5da3e8b87e8a245e0e08f97

comment:6 Changed 6 years ago by ianbush

  • Status changed from verifying to closed

Merge pull request #135 from mantidproject/feature/10934_cut_md_fix

refs #10934. Fix 4d problem.

Full changeset: ​51986bc0489c50c4a5da3e8b87e8a245e0e08f97

comment:7 Changed 6 years ago by Martyn Gigg

  • Status changed from closed to verifying
  • Tester changed from Ian Bush to Martyn Gigg

comment:8 Changed 6 years ago by Owen Arnold

  • Status changed from verifying to verify
  • Tester Martyn Gigg deleted

comment:9 Changed 6 years ago by Ian Bush

  • Status changed from verify to verifying
  • Tester set to Ian Bush

comment:10 Changed 6 years ago by Ian Bush

  • Status changed from verifying to closed

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11773

Note: See TracTickets for help on using tickets.