Drag-drop peaks only

[Owen Arnold]

Simple test. Run this. and note that we add the same peaks workspace twice

Load(Filename='CNCS_7860_event.nxs', OutputWorkspace='CNCS_7860_event', LoaderName='LoadEventNexus', LoaderVersion=1)
ConvertToDiffractionMDWorkspace(InputWorkspace='CNCS_7860_event', OutputWorkspace='trial', SplitThreshold=50, Extents='-1,1,-1,1,-1,1')

svw = plotSlice('trial')
sv = svw.getSlicer()

peaks=FindPeaksMD(InputWorkspace='trial', MaxPeaks=1)
peaks1 = FindPeaksMD(InputWorkspace='trial', MaxPeaks=2)
peaks2 = FindPeaksMD(InputWorkspace='trial', MaxPeaks=3)

sv.setPeaksWorkspaces([peaks, peaks1, peaks2])
sv.setPeaksWorkspace([peaks])

Now go through and hit 'Remove' against each peaks workspace in the SliceViewer. The PeaksViewer should close.

There are a couple of things here:

1) Roman has indicated that there is a spurious crash with the peaksoverlays when the button is used in conjunction with the drag-drop

2) We only want to drag-drop now anyway as this fits with the existing tools such as the instrument view

3) When you remove all peaksoverlay widgets, it should detach the peaksviewer. If this works then we are in a better place to disable the existing peaks overlay button. The reason that it currently does not work (one edge case) is that the compositepeakspresenter allows you to multiply add the same peaks workspace. This does not result in a new widget, but it does get tracked in the presenter code. We can fix this by properly determining if the incoming presenter is managing any workspaces that the composite currently knows about. If it is, then it should NOT be added.

For now, I'm going to leave the push button in place, but disable it. I want to check with users what they want to happen to this in the future. Ideally I'll remove it altogether.

[Owen Arnold]

refs #10946. Test and Fix issue.

We use the sets for each presenter to calculate the difference. If the difference between the peaks workspace is the same as the original set, then there is no overlap, and we may accept that presenter.

A number of unit tests have been introduced to verify this.

Changeset: dc17ec1a86d064814a85201037ce5c373fe9aa92

[Owen Arnold]

This is being verified as ​pull request #138.

[Roman Tolchenov]

Merge pull request #138 from mantidproject/feature/10946_drag_drop_only

Drag-drop peaks only

Full changeset: ​1d1d3f2ece5af540436785197783dcb4813f9b50

[Stuart Campbell]

This ticket has been transferred to github issue ​11785