Ticket #10958 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Update reduction wrapper according to current web services state

Reported by: Alex Buts Owned by: Alex Buts
Priority: major Milestone: Release 3.4
Component: Direct Inelastic Keywords:
Cc: Blocked By: #10881
Blocking: #10684 Tester: Ian Bush

Description (last modified by Alex Buts) (diff)

When writing reduction wrapper, I was expecting web service to be written as a factory with reduction being a subscriber.

Web service is currently done in a bit different way, which causes inefficiencies & inconveniences in reduction wrapper. In addition to that, it is clear now how multiple runs are handled and what are user requests to do that from web and desktop -- this should be reconciled and satisfied.

This work would allow to test new reduction in all instances on non-event mode instruments and obtain an early feedback on this reduction. This is why it goes before #10684.

Change History

comment:1 Changed 6 years ago by Alex Buts

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Alex Buts

  • Description modified (diff)

comment:3 Changed 6 years ago by Alex Buts

  • Status changed from assigned to inprogress

Re #10958 Initial commit. (Nothing working yest)

Changeset: 4235123db5ff8ec035e9d37798a14fb0c9f9c044

comment:4 Changed 6 years ago by Alex Buts

Re #10958 Intermediate checkout

Changeset: 5ae5c459ad25d6f759e52a0ac24010f22ec61bcb

comment:5 Changed 6 years ago by Alex Buts

Re #10958 ReductionWrapper modified to run in web-like way

Changeset: e0e2f49a8034dace0b3d8bf6ddd131e854153689

comment:6 Changed 6 years ago by Alex Buts

Re #10958 One more system test for MARI when one tries to run it

like from the web service. Changes to Merlin and Mari reduction to support new ReductionWrapper

Changeset: 4e4224772dd575847b585c81726626200409ee55

comment:7 Changed 6 years ago by Alex Buts

Re #10958 Fixed output workspace name

Changeset: eabee4d50ce60fa39d4090f928af4b346d3e0fa9

comment:8 Changed 6 years ago by Alex Buts

Re #10958 Modified ISIS system tests to new interface

Changeset: 6ad03d483667cc9905a71f0bb6cc23f8826e4e52

comment:9 Changed 6 years ago by Alex Buts

Re #10958 minor comments

Changeset: dcf85543a770979c072a66cb1a6bb4249470b5a2

comment:10 Changed 6 years ago by Alex Buts

Re #10958 fixed reduce return in case of multiple workspaces

(multirep mode)

Changeset: 485df58b0bc6d5ae7c8d9abc7789ad32c09cd131

comment:11 Changed 6 years ago by Alex Buts

Re #10958 Minor comments

Changeset: 0dfb5723a8fceb108e5057e594a6eb8d78d16f26

comment:12 Changed 6 years ago by Alex Buts

Re #10958 Fixed separate/common monitor loading

Changeset: 15c07d12ea69c23bacc9e42347cb7600f90d08b1

comment:13 Changed 6 years ago by Alex Buts

Re #10958 Minor cosmetic changes to system tests related

to changes in Mantid branch

Changeset: 316f3de0755a1a12e8e21c10129bebe5924efcce

comment:14 Changed 6 years ago by Alex Buts

Re #10958 Validate method in reduction wrapper

Changeset: 3c5c1ffd429884a722c14a10c6334c092752ffba

comment:15 Changed 6 years ago by Alex Buts

Re #10958 System, test to validate method in reduction wrapper

Changeset: ae7cbab078f5da01c8e354bc91832236202a4ca5

comment:16 Changed 6 years ago by Alex Buts

Re #10958 Fixed "Wait for file" mode

Changeset: e16d365d483e2f6ee8d62c9b5d8479d1637c9ca2

comment:17 Changed 6 years ago by Alex Buts

Re #10958 Fixing system tests

and adding comments on why some a failing and what can be done to avoid it

Changeset: c13e458d71b88af71fee9793cec43dad67581664

comment:18 Changed 6 years ago by Alex Buts

Re #10958 Just formatting

Changeset: bf0a58de45011d524b3599001eaec0385cab5b09

comment:19 Changed 6 years ago by Alex Buts

Re #10958 Separated sum_runs and sample_run

This allows better separation of cases when runs are summed or considered one-by one

Changeset: 58103f20c1cc541389b06345316c2be00e0b4cbc

comment:20 Changed 6 years ago by Alex Buts

Re #10958 Introducing run_list

Changeset: 08c98d0903a6b5f57aa48a9915282ad8eeeade2b

comment:21 Changed 6 years ago by Alex Buts

Re #10958 Minor comments

Changeset: 92179172f9213793ce2f5b0d4bc10dfc13958426

comment:22 Changed 6 years ago by Alex Buts

Re #10958 Bug in summation and better results validator

Changeset: 56919cfbf951090578d0f617d66ce2feb9eaf262

comment:23 Changed 6 years ago by Alex Buts

Re #10958 Enhanced validation procedure

Changeset: 301b35b94dc85414041cdd798b7224eb5e89df3b

comment:24 Changed 6 years ago by Alex Buts

Re #10958 Minor pylint warnings

Changeset: 314f3b0e873ddb7dd155ca35247506222e56fbff

comment:25 Changed 6 years ago by Alex Buts

Re #10958 Pylint warnings

Changeset: 7d734cc700f5dd8633849b7eb57c03ae744ed272

comment:26 Changed 6 years ago by Alex Buts

Re #10958 Fixing error caused by following pylint suggestions

This pylint is not harmless at all

Changeset: a562cd23699f5bebafab1859aafdd64f5e6b4ff1

comment:27 Changed 6 years ago by Alex Buts

Re #10958 Minor bugs in validate_result ReductionWrapper script

Changeset: 7ca2f6388fe302a5e374f2492729df40014e4ff9

comment:28 Changed 6 years ago by Alex Buts

  • Status changed from inprogress to verify
  • Resolution set to fixed

Changes are both in Mantid and System test directory as I've written&modified number of tests to validate the changes.

The changes in the ticket allow to take most of current state of the Autoreduction service.

I've also separated RunDescriptor and summation class, which should allow to sum runs provided as list of run numbers in autoreduction. It is not done very nicely, but should work. I will refactor this change later, which would also allow data accumulation.

Minimal testing relies to all system test passing.

If tester decides to proceed with code review, please talk to me -- I am not very satisfied with current changes code, but have to finish ticket #10684 first.

comment:29 Changed 6 years ago by Alex Buts

  • Status changed from verify to reopened
  • Resolution fixed deleted

system test have problem they did not have before

comment:30 Changed 6 years ago by Alex Buts

  • Status changed from reopened to inprogress

Re #10958 Fixing errors, induced by pylint

Changeset: 9700712e123326bb87b2eaa8fbb798515a59dce7

comment:31 Changed 6 years ago by Alex Buts

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:32 Changed 6 years ago by Ian Bush

System tests and unit tests all run ok, and changes look sensible, so accepting.

comment:33 Changed 6 years ago by Ian Bush

  • Status changed from verify to verifying
  • Tester set to Ian Bush

comment:34 Changed 6 years ago by Ian Bush

  • Status changed from verifying to closed

comment:35 Changed 6 years ago by Ian Bush

Merge remote-tracking branch 'origin/feature/10958_UpdatedReductionWrapper'

Full changeset: 9769182cc72611f66b59e8c239ee96a9155863cc

comment:36 Changed 6 years ago by Ian Bush

Merge remote-tracking branch 'origin/feature/10958_UpdatedReductionWrapper'

Full changeset: 9769182cc72611f66b59e8c239ee96a9155863cc

comment:37 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11797

Note: See TracTickets for help on using tickets.