BugFix: SliceAlgorithmDialog sends incorrect dimension information

[Anton Piccardo-Selg]

To reproduce:

1. Load two event MD event workspaces into MantidPlot of which one has three dimensions and the other has four dimensions.
2. Execute the BinMD algorithm. The BinMD algorithm dialog will appear.
3. Load the four-dim workspace and bin it.
4. Execute the BinMD algorithm. The BinMD algorithm dialog will appear.
5. Load the three-dim workspace and bin it.
6. You shoud see an error message.

The dialog memorises the strucutre of the workspace which was loaded last. When you load the four-dim workspace it creates a dimension property which is four-dim. Then when we switch to a three-dim workspace the last dimsion structure is not flushed from the dimension property

[Anton Piccardo-Selg]

Refs #10959 Fix the slice algorithm dialog dimension issue

Changeset: 06356e112acd08f30c8f38207a6aa2d54a05dd93

[Anton Piccardo-Selg]

Refs #10959 Moving slice algorithm dialog to MantidWidgets

Changeset: 179be9b43fb92f29da7e41add2f96c3d7db00b47

[Anton Piccardo-Selg]

For testing:

You need two workspaces for testing: MDEvent1 which is 4D and MDEvent2 which is 3D. I could attach only MDEvent1 due to the size limit. Please ask me for the other workspace which I will email to you.

Essentially we want to make sure that there are no error messages or warnings when we perform BinMD and that the output workspaces are being produced.

1. Load both workspaces
2. Open the BinMD dialog (search for it in the algorithm search bar), select MDEvent1 as the input workspace and name the output workspace "out1"
3. Perform the binning.
4. Confirm that there are no error messages in the "Results log"
5. Confirm that the workspace "out1" has the correct dimensional information (i.e. the bins are what you had set them to)
6. Open the BinMD dialog, select MDEvent2 as the input workspace and name the output workspace "out2"
7. Perform the binning.
8. Confirm that there are no error messages in the "Results log". Note, that the error was at this point.
9. Confirm that the workspace "out2" has the correct dimensional information (i.e. the bins are what you had set them to)

Please code review this

[Anton Piccardo-Selg]

Please see comment: 3 for test instructions

[Roman Tolchenov]

Merge remote-tracking branch 'origin/bugfix/10959_fix_slice_algorithm_dialog_dimension_issue'

Full changeset: ​3a70f9fc3d18e8e485ecba302f6ceb8ceb2db8d1

[Roman Tolchenov]

Merge remote-tracking branch 'origin/bugfix/10959_fix_slice_algorithm_dialog_dimension_issue'

Full changeset: ​3a70f9fc3d18e8e485ecba302f6ceb8ceb2db8d1

[Stuart Campbell]

This ticket has been transferred to github issue ​11798