Ticket #10962 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

MDWorkspaceTests, in SystemTests, fails to clean up files it creates

Reported by: Ian Bush Owned by: Ian Bush
Priority: minor Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Federico M Pouzols

Description

System test MDWorskapceTests.MergeMDTest fails to remove some files it creates on Ubuntu 14.04:

MDWorkspaceTests-[Notice] Failed to remove CNCS_7860_event_rotated_000.nxs MDWorkspaceTests-[Notice] Failed to remove CNCS_7860_event_rotated_001.nxs MDWorkspaceTests-[Notice] Failed to remove CNCS_7860_event_rotated_002.nxs MDWorkspaceTests-[Notice] Failed to remove CNCS_7860_event_rotated_003.nxs MDWorkspaceTests-[Notice] Failed to remove CNCS_7860_event_rotated_004.nxs MDWorkspaceTests-[Notice] Failed to remove merged.nxs

This means running the system tests for a second time causes MergeMDTest to fail when it tries to write to merge to merged.nxs. Test should be changed to use absolute paths. This is not seen on build servers as files are automatically cleaned.

Change History

comment:1 Changed 6 years ago by Ian Bush

Refs #10962 Use absolute paths in MergeMDTest, as used in PlusMDTest, to prevent bug when trying to merge to already existing NeXus MD file.

Changeset: 66db7cd337d91c521935c2775e7f75b5dd3ff438

comment:2 Changed 6 years ago by Ian Bush

  • Status changed from new to assigned
  • Owner set to Ian Bush

comment:3 Changed 6 years ago by Ian Bush

  • Status changed from assigned to inprogress

comment:4 Changed 6 years ago by Ian Bush

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test this check than the build server system tests on all platforms do not leave any of the following files in the logs folder:

MDWorkspaceTests-[Notice] Failed to remove CNCS_7860_event_rotated_000.nxs MDWorkspaceTests-[Notice] Failed to remove CNCS_7860_event_rotated_001.nxs MDWorkspaceTests-[Notice] Failed to remove CNCS_7860_event_rotated_002.nxs MDWorkspaceTests-[Notice] Failed to remove CNCS_7860_event_rotated_003.nxs MDWorkspaceTests-[Notice] Failed to remove CNCS_7860_event_rotated_004.nxs MDWorkspaceTests-[Notice] Failed to remove merged.nxs

The logs folder can be viewed on Jenkins via the Workspace option on the view of the completed system tests.

Also can check these files are not left locally when running the system tests. Running MDWorkspaceTests twice in a row should be successful, having failed before this fix. Ideally test this locally on Windows.

comment:5 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:6 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to verify
  • Tester Harry Jeffery deleted

Tested locally on Ubuntu 14.04, works as described.

Logs folder on Jenkins also appears to be correct.

comment:7 Changed 6 years ago by Federico M Pouzols

I just tested this locally on windows. I think this is working well and could be merged, or do you think it should also be checked locally on a mac?

comment:8 Changed 6 years ago by Ian Bush

It looks like things are working on develop_systemtests_all for Mac, so this should be safe to merge.

comment:9 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

comment:10 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10962_MDWorkspaceTests_clean_up'

Full changeset: ​a6ea9d184578962d7700f035961e7014b0494e35

comment:11 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11801

Note: See TracTickets for help on using tickets.