Ticket #11005 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

New adaptive radius binning

Reported by: Peter Peterson Owned by: Vickie Lynch
Priority: major Milestone: Release 3.4
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Federico Montesino Pouzols

Description (last modified by Peter Peterson) (diff)

​IntegratePeaksMD should be modified to have the peak integration vary on a line, such as radius=m*Q+b, with b being the current parameter PeakRadius. Modify AdaptiveQRadius to specify a linear term (m above), or remove that parameter and specify one with a better name. An additional (boolean) parameter will specify whether the background radii should be modified by the equation as well.

This is follow-on work to #7898 and #7949.

Change History

comment:1 Changed 6 years ago by Peter Peterson

  • Description modified (diff)

comment:2 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Vickie Lynch

  • Status changed from assigned to inprogress

Refs #11005 radius=mQ+b

Changeset: f28e6e4c4577adbc88e664e8ca3badb957c066ef

comment:4 Changed 6 years ago by anonymous

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #454.

comment:5 Changed 6 years ago by anonymous

retest this please

comment:6 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico Montesino Pouzols

comment:7 Changed 6 years ago by Federico Montesino Pouzols

This fixes trac ticket #11005(​http://trac.mantidproject.org/mantid/ticket/11005).

comment:8 Changed 6 years ago by Federico Montesino Pouzols

Code changes look good and it behaves well.

I'd suggest adding a test case in IntegratePeaksMD2Test to cover the two new properties added here. Or, if this is not feasible with the small/toy data available in unit tests, maybe something along the lines of the test script given in the PR description could be added in the system tests. I'm not very familiar with those system tests, but at first look Diffraction_Workflow_Test seems a good place.

comment:9 Changed 6 years ago by Federico Montesino Pouzols

Merge pull request #454 from mantidproject/11005_adaptive_radius_binning

Refs #11005 radius=mQ+b

Changeset: bbf1de2beb6b99159836b83f3a379e1e5d90dd00

comment:10 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from verifying to closed

Merge pull request #454 from mantidproject/11005_adaptive_radius_binning

Refs #11005 radius=mQ+b

Full changeset: ​bbf1de2beb6b99159836b83f3a379e1e5d90dd00

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11844

Note: See TracTickets for help on using tickets.