Ticket #11048 (closed: fixed)
IndirectInstrumentConfig does not set the instrument for MWRunFiles
| Reported by: | Dan Nixon | Owned by: | Dan Nixon |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 3.4 |
| Component: | Indirect Inelastic | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Harry Jeffery |
Description
MWRunFiles finds files for the default instrument, so now finds the wrong files when used on the indirect interfaces.
I'm reluctant to start setting the default instrument again as this caused more issues that it's worth, instead add a property to MWRunFiles to override the instrument, if set with an empty string then use the set default.
Change History
comment:3 Changed 6 years ago by Dan Nixon
- Status changed from assigned to inprogress
Allow searching for a given instrument in file finder
Refs #11048
Changeset: 38a3add599719d0ae6f7b554d3919f8af7beaa90
comment:5 Changed 6 years ago by Dan Nixon
Add option to MWRunFiles to lock to inst
Refs #11048
Changeset: c07e9091f70d08352073402e3b69b4262b2ea5cc
comment:6 Changed 6 years ago by Dan Nixon
Change over indirect use of MWRunFiles to give instrument
Refs #11048
Changeset: 0ac610d8530cdaa852ec63a9c7940f83f6ac5f1f
comment:7 Changed 6 years ago by Dan Nixon
Add option to MWRunFiles to lock to inst
Refs #11048
Changeset: 2737d78519115acab966026604de7449b680f5ba
comment:8 Changed 6 years ago by Dan Nixon
Change over indirect use of MWRunFiles to give instrument
Refs #11048
Changeset: bd06ef4069497cfc5dcd343e1bc07f8090b58c82
comment:9 Changed 6 years ago by Dan Nixon
Implement Regex based fix for MWRunFiles
Refs #11048
Changeset: 25307c9b04428041155ed27029ddb8d715dd3d1f
comment:10 Changed 6 years ago by Dan Nixon
Add fix for data selector and fix Transmission UI
Refs #11048
Changeset: 651163a6a2851b73fb3ac8929ff31a6eca9e0694
comment:11 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #199.
comment:12 Changed 6 years ago by Harry Jeffery
- Status changed from verify to verifying
- Tester set to Harry Jeffery
comment:13 Changed 6 years ago by Harry Jeffery
Transmission tab seems to still be looking for TOSCA files on my system.
comment:14 Changed 6 years ago by Harry Jeffery
- Status changed from verifying to closed
Merge pull request #199 from mantidproject/feature/11048_mwrunfiles_instrument_override_property_take_2
Allow MWRunFiles to take a default instrument and fix Indirect UIs
Full changeset: f89f29fd9e65448ef21730659600aa5b38b1bcdc
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11887
