Ticket #11049 (closed: fixed)
InstrumentSelector should not change the default facility/instrument
| Reported by: | Martyn Gigg | Owned by: | Dan Nixon |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.4 |
| Component: | GUI | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Harry Jeffery |
Description
The instrument selector widget currently changes the default.instrument, which can causes problems when multiple interfaces are opened and I don't think it is what a user would actually expect.
The default instrument and facility should just be used for a first time run to select what should be shown and from then on ignored.
Change History
comment:2 Changed 6 years ago by Dan Nixon
- Status changed from new to assigned
- Owner set to Dan Nixon
comment:4 Changed 6 years ago by Dan Nixon
- Status changed from assigned to inprogress
By default do not touch default instrument.
Verified that first time setup and config UIs still work.
Refs #11049
Changeset: 999fbb70dd4109cd6b4e388b848802845770cc50
comment:6 Changed 6 years ago by Dan Nixon
The remaining UIs that seem to use this are:
- DirectConvertToEnergy.ui
- Muon/MuonAnalysis.ui
comment:7 Changed 6 years ago by Dan Nixon
Fix file loading on Muon Analysis UI
Refs #11049
Changeset: 29ce124d0719b7d41d21f33a9c6db57240a0a391
comment:8 Changed 6 years ago by Dan Nixon
Fix file loading on Direct Convert to Energy
Refs #11049
Changeset: c69586722df29ac8bc9df5d262e916c05198baca
comment:9 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #223.
comment:10 Changed 6 years ago by Dan Nixon
Jenkins, retest this please.
comment:11 Changed 6 years ago by Dan Nixon
Jenkins, retest this please.
comment:12 Changed 6 years ago by Harry Jeffery
- Status changed from verify to verifying
- Tester set to Harry Jeffery
comment:13 Changed 5 years ago by Nick Draper
- Status changed from verifying to closed
This has been merged
comment:14 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11888
I think the option to have it change the instrument is OK (since the same widget is used in the config and first time setup UIs) but should be disabled by default and the remaining UIs that rely on it modified, which should be simple enough after #11048 introduced the changes to data selection widgets to make this possible.