Ticket #11053 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Feature: Display Peak information in Splatterplot in the VSI

Reported by: Anton Piccardo-Selg Owned by: Anton Piccardo-Selg
Priority: major Milestone: Release 3.4
Component: GUI Keywords: VATES
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

We want to be able to display the coordinate inforamtion of Peak Workspaces in the Splatterplot view in the VSI.

Ideally this is displayed next to the rendered peaks.

Attachments

Test instructions with the peak workspace.docx (30.5 KB) - added by Anton Piccardo-Selg 6 years ago.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Anton Piccardo-Selg

  • Status changed from assigned to inprogress

Refs #11053 Resolve rebase conflict

Changeset: d165ed479aef8a831774af7f7271c6cb932d086e

comment:3 Changed 6 years ago by Anton Piccardo-Selg

Refs #11053 Adding peaks table to splatterplot

Changeset: 93dd65a2891990f170177c93ab3f6f5ce7679b03

comment:4 Changed 6 years ago by Anton Piccardo-Selg

Refs #11053 Added peak filter

Changeset: 8a70759fe2302abf2129170f75307680f83e6f14

comment:5 Changed 6 years ago by Anton Piccardo-Selg

Refs #11053 Added ellipsoidal glyphs

Changeset: 7662229ba3250b6531c840000c882b905bc522f5

comment:6 Changed 6 years ago by Anton Piccardo-Selg

Refs #11053 Added unit tests for vtkDataSetToPeaksFilteredDataSet

Changeset: 5bff3de725d0377439c41f94385974a2e3a79855

comment:7 Changed 6 years ago by Anton Piccardo-Selg

Refs #11053 Resolve merge issues

Changeset: 379649936bb8fb4d355d5288f56bee03a26d0d33

comment:8 Changed 6 years ago by Anton Piccardo-Selg

Refs #11053 Added specific frame direction for ellipsoidal peaks

Changeset: bd86997ccd5401d86a114db3739c0d48cbbbc773

comment:9 Changed 6 years ago by Anton Piccardo-Selg

Refs #11053 Add peak marker source

Changeset: 6c1d583dae1a3ecc64c6b34165acad30b581b19a

comment:10 Changed 6 years ago by Anton Piccardo-Selg

Refs #11053 Update peaks filter

Changeset: 8c81d2f7fad9a27d9b71673b1c28bc8cf05b3b0d

comment:11 Changed 6 years ago by Anton Piccardo-Selg

Refs #11053 Adding meta data stuff to scale workspace

Changeset: f864b70090ec3605d92225c8f5106c2156310eb4

comment:12 Changed 6 years ago by Anton Piccardo-Selg

Refs #11053 Add peaks table in splatterplot

Changeset: a21a9bb2759e6b790251053ded70069c8bf82df1

comment:13 Changed 6 years ago by Anton Piccardo-Selg

Refs #11053 Correct destruction of filters and sources for splatPlot

Changeset: 21d2a96cb4ddd4a2134e0d548b5b720884be9951

comment:14 Changed 6 years ago by Anton Piccardo-Selg

Refs #11053 Adding more unit tests for peaks filter

Changeset: 3f007812f9d5d5faea083adef27e24c8a279c34a

comment:15 Changed 6 years ago by Anton Piccardo-Selg

Refs #11053 Adding unit tests and peak fixes

Changeset: c2139ae3feb767cd874e405924800f81997a9046

comment:16 Changed 6 years ago by Anton Piccardo-Selg

Refs #11053 Tidying up test code

Changeset: ce23263025c004c234957f9aecca07d273cb132c

Changed 6 years ago by Anton Piccardo-Selg

comment:17 Changed 6 years ago by Anton Piccardo-Selg

Last edited 6 years ago by Anton Piccardo-Selg (previous) (diff)

comment:18 Changed 6 years ago by Anton Piccardo-Selg

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #381.

comment:19 Changed 6 years ago by Anton Piccardo-Selg

Refs #11053 Fix a definition error

Changeset: d57df29d1110f778731baa809a2ade40c2db06d6

comment:20 Changed 6 years ago by Anton Piccardo-Selg

Refs #11053 Fix issue in compositePeaksPresenterVsi

Changeset: 6677e73ac27067a734b525f7755e2ba22ae26b2c

comment:21 Changed 6 years ago by Anton Piccardo-Selg

Refs #11053 Added missing include

Changeset: 7923ef122c517fb3031deeb00116b2f3b8b86b07

comment:22 Changed 6 years ago by Anton Piccardo-Selg

Refs #11053 Resolve merge conflicts

Changeset: 6ef8e0ff467bc95796ce43c51fd8e8716df17012

comment:23 Changed 6 years ago by Anton Piccardo-Selg

Refs #11053 Fix issue in vtkDataSetToPeaksFilteredDataSet

Changeset: 7011e3de20fcb9a8751c84faba963c3059e4e350

comment:24 Changed 6 years ago by Anton Piccardo-Selg

Refs #11053 Remove CutMD and fix issues

Changeset: 5bef300df756dcfce1c2790c0426f7422ec45faf

comment:25 Changed 6 years ago by Anton Piccardo-Selg

Refs #11053 Resolve merge conflict

Changeset: 32720379e96c0f9a606d6864c5887f5d8552bf20

comment:26 Changed 6 years ago by Anton Piccardo-Selg

Refs #11053 Fixing some compiler warnings

Changeset: d944f5caadedc42a7086f53ad6e9c9c3632c6cc3

comment:27 Changed 6 years ago by Anton Piccardo-Selg

Refs #11053 Fix frame issue

Changeset: 1e57f1ce6870982414a60352e831c1512b4fec53

comment:28 Changed 6 years ago by Anton Piccardo-Selg

Refs #11053 Several changes to mocked peaks

Changeset: 38e40714808589f99a6cba02631f09b7ea61738d

comment:29 Changed 6 years ago by Anton Piccardo-Selg

Jenkins, retest this please

comment:30 Changed 6 years ago by Anton Piccardo-Selg

Refs #11053 Fix unit test for rhel6

Changeset: de65fb859b91fd342cd1615cd21d2a23e2c27aa3

comment:31 Changed 6 years ago by Anton Piccardo-Selg

Refs #11053 Fix include issue

Changeset: 68cecec1bfb80949402304235f2b75e744cb1774

comment:32 Changed 6 years ago by Anton Piccardo-Selg

Jenkins, retest this please

comment:33 Changed 6 years ago by Anton Piccardo-Selg

Jenkins, retest this please

comment:34 Changed 6 years ago by Anton Piccardo-Selg

Jenkins, retest this please

comment:35 Changed 6 years ago by Anton Piccardo-Selg

Refs #11053 Fix doxygen warnings

Changeset: f794eacaa2e4a8c8c673c681ddb17ab0f891bab0

comment:36 Changed 6 years ago by Owen Arnold

jenkins retest this please

comment:37 Changed 6 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:38 Changed 6 years ago by Owen Arnold

Jenkins retest this please

comment:39 Changed 6 years ago by Owen Arnold

jenkins retest this please

comment:40 Changed 6 years ago by Owen Arnold

refs #11053. Disable spurious warning.

Changeset: 54215f06ac991e8673e94fb4e0baeb3e0599c097

comment:41 Changed 6 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge pull request #381 from mantidproject/feature/11053_peak_table_in_splatterplot_in_vsi

Peak table in splatterplot in vsi

Full changeset: 60beb5c101e2eeb102938b783967c2c7b9ad821a

comment:42 Changed 6 years ago by Owen Arnold

I've made some minor changes to kill one of the warnings on RHEL6, but other than that all the code is Antons. This is working the way I would expect it to. I also have some minor comments about the code.

comment:43 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11892

Note: See TracTickets for help on using tickets.