Ticket #11061 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Coverity issues: a bunch of memory, initialization and other issues

Reported by: Federico M Pouzols Owned by: Federico M Pouzols
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: #10619 Tester: Pete Peterson

Description (last modified by Federico M Pouzols) (diff)

Fix these issues (most of them in Framework):

  • 1076125: apparently 'const' qualifier missing for the print method.
  • 1076078 and 1076079: (LeBailFit and SaveIsawUB) passing these parameters as const references?
  • 1075946: Interpolation (in MantidPlot): use delete[].
  • 1241920: (loadFITS) initialize m_spectraCount, m_progress in constructor.
  • 1075410: (LoadEventNexus): initialize loadlogs in constructor
  • 1075409: (LoadEventPreNexus): init in constructor
  • 1075408: (LoadEventPreNexus2): init in constructor
  • 1075388: (EventWorkspace): init in constructor
  • 1075406: (LoadISISNexus2): same
  • 1147106: (LoadAscii2): init
  • 1075400: (LoadRaw3): init
  • 1075319: (NexusFileIO)
  • 1075320: (NexusFileIO)

Change History

comment:1 Changed 6 years ago by Federico M Pouzols

  • Blocking 10619 added

(In #10619) Added a couple of Coverity tickets that come with a bunch of Nexus, Instrument, Logs, related issues.

comment:2 Changed 6 years ago by Federico M Pouzols

  • Description modified (diff)

comment:3 Changed 6 years ago by Federico M Pouzols

  • Description modified (diff)

comment:4 Changed 6 years ago by Federico Montesino Pouzols

fix coverity issues 1075319, 20 (initialize), re #11061

Changeset: 912e39a2d07e5fcef7f38b54f72fe4c493803f2d

comment:5 Changed 6 years ago by Federico Montesino Pouzols

fix coverity issue 1075388 (initialize), re #11061

Changeset: 7900eeffb3c2fe5c0a8e6532788f564a71f05c52

comment:6 Changed 6 years ago by Federico Montesino Pouzols

fix coverity issue 1075400 (initialize), re #11061

Changeset: 28db6201aef6d1dd354904c6e3f3355a3b98b177

comment:7 Changed 6 years ago by Federico Montesino Pouzols

fix coverity issue 1147106 (initialize), re #11061

Changeset: d21be66e395efc147509ceb0611e0437e1f387ed

comment:8 Changed 6 years ago by Federico Montesino Pouzols

fix coverity issues 1076078, 9 (pass by ref), re #11061

Changeset: 10fc43d6249bd5b1e7e9e726590eff2906d217d8

comment:9 Changed 6 years ago by Federico Montesino Pouzols

fix coverity issue 1076125 (constness - hide/overwrite), re #11061

Changeset: 7cac90bbcff0d77436cef074c435b979b1c1e420

comment:10 Changed 6 years ago by Federico Montesino Pouzols

fix coverity issue 1076079 (pass by ref), re #11061

Changeset: ceb348e0e0b0eda5865bed8a25654087fbcbba57

comment:11 Changed 6 years ago by Federico Montesino Pouzols

fix coverity issue 1075946 (delete[]), re #11061

Changeset: cbaa20900c567d62862363b0feac1a6a671ea144

comment:12 Changed 6 years ago by Federico Montesino Pouzols

fix coverity issue 1075410 (initialize), re #11061

Changeset: 11db12067ab2cdc34d72b21e59eb37b5abb3c065

comment:13 Changed 6 years ago by Federico Montesino Pouzols

fix coverity issue 1241920 (initialize), re #11061

Changeset: 83389ae59ab62df5624b7b6d8d685307250f29c2

comment:14 Changed 6 years ago by Federico Montesino Pouzols

fix coverity issue 1075406 (init in construtor), re #11061

Changeset: 768d77d121e6a1a6e82eedf74d9926019dca5826

comment:15 Changed 6 years ago by Federico Montesino Pouzols

fix coverity issue 1075409 (init in construtor), re #11061

Changeset: 7652f02b218454bd2df084f76832d58289c000db

comment:16 Changed 6 years ago by Federico Montesino Pouzols

fix coverity issue 1075408 (init in construtor), re #11061

Changeset: fe3e5a64976565940a6e4bb41d6646651ff20afe

comment:17 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:18 Changed 6 years ago by Federico M Pouzols

  • Status changed from assigned to verify
  • Resolution set to fixed

This is being verified as ​pull request #278.

comment:19 Changed 6 years ago by Federico Montesino Pouzols

fix boost::shared_ptr constructors, re #11061

Changeset: 6e7515fc79e78207df91effd76493751ca3ea5de

comment:20 Changed 6 years ago by Federico M Pouzols

Jenkins, retest this please.

comment:21 Changed 6 years ago by Federico M Pouzols

Jenkins retest this please

comment:22 Changed 6 years ago by Pete Peterson

  • Status changed from verify to verifying
  • Tester set to Pete Peterson

comment:23 Changed 6 years ago by Pete Peterson

  • Status changed from verifying to closed

Merge pull request #278 from mantidproject/11061_coverity_issues_framework_memory_initialization_etc

Fix initialization etc. coverity issues in Framework

Full changeset: ​9d1433157e2798fcd67c097b421ffb37935e42f8

comment:24 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:25 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11900

Note: See TracTickets for help on using tickets.