Ticket #11062 (closed: fixed)
Coverity: potential null pointer issues
| Reported by: | Federico M Pouzols | Owned by: | Federico M Pouzols |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.4 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #10619 | Tester: | Harry Jeffery |
Description (last modified by Federico M Pouzols) (diff)
Fix these ones (Framework, potential null dereference after dynamic casts):
- 1075920: Integration algorithm
- 1075928, 1075929, 1075930: CreateWorkspace algorithm
- 1075935: PropertyNexus - check null pointer
- 1075936: Algorithm: check null pointer
- 1076296: Detector, dynamic_cast
- 1076298: Detector, dynamic_cast
- 1076305 and 1076306: ProcessDasNexusLog, dynamic casts
- 1076307: LoadInstrument::exec
- 1076308: LoadNexusLogs::exec
- 1076313: LoadEventNexus::exec
- 1231789: LoadEventNexus::runLoadNexusLogs
These ones have a bit of focus on load/Nexus and related classes.
Change History
comment:2 Changed 6 years ago by Federico M Pouzols
- Status changed from new to assigned
- Description modified (diff)
comment:3 Changed 6 years ago by Federico Montesino Pouzols
- Status changed from assigned to inprogress
fix coverity issue 1075920 (null deref), re #11062
Changeset: 308aa94bd1eb0d0e9b148dd0fc8a4a947133ba3f
comment:4 Changed 6 years ago by Federico Montesino Pouzols
fix coverity issues 1075928,29,30 (null derefs), re #11062
Changeset: 7a4bd08cab5dd49cac4fa654059ae8f05d19a340
comment:5 Changed 6 years ago by Federico Montesino Pouzols
fix coverity issue 1075935 (null deref), re #11062
Changeset: f260ce47f30f7a980bc52b87ac6d8029c82ca1a5
comment:6 Changed 6 years ago by Federico Montesino Pouzols
fix coverity issue 1075936 (null deref), re #11062
Changeset: c35eb67b3fb3832f61bc458bfdd458c3a2a4b8da
comment:7 Changed 6 years ago by Federico Montesino Pouzols
fix coverity issue 1076307 (null deref), re #11062
Changeset: fd65c2527a6314b0ee8e672f071778b90964ed7f
comment:8 Changed 6 years ago by Federico Montesino Pouzols
fix coverity issues 1076305,6 (null deref), re #11062
Changeset: ee7edf4a3daeafa2a751a034111e22ecd3ae4374
comment:9 Changed 6 years ago by Federico Montesino Pouzols
fix coverity issue 1076308 (null deref), re #11062
Changeset: 7387264c151faaa7434611eadf5e6db85ed5535a
comment:10 Changed 6 years ago by Federico Montesino Pouzols
fix coverity issues 1076296, 98 (null deref), re #11062
Changeset: 48820939de7665513f427b91ecadbffdceb02df7
comment:11 Changed 6 years ago by Federico Montesino Pouzols
fix coverity issues 1076313 & 1231789 (null derefs), re #11062
Changeset: 98947f77585af4e0d38012899a9233c4edcb8b54
comment:12 Changed 6 years ago by Federico M Pouzols
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #218.
comment:13 Changed 6 years ago by Harry Jeffery
- Status changed from verify to verifying
- Tester set to Harry Jeffery
comment:14 Changed 6 years ago by Harry Jeffery
Other than the two points I've raised above, the changes look good :)
comment:15 Changed 6 years ago by Harry Jeffery
- Status changed from verifying to closed
Merge pull request #218 from mantidproject/11062_coverity_issues_framework_algorithms_and_nexus
Coverity issues in framework: algorithms and nexus load*
Full changeset: b4e4a6f034f31c4330436c7d0b33301b38b2689a
comment:16 Changed 5 years ago by Nick Draper
Somehow these slipped through without a resolution. Set to Fixed.
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11901
(In #10619) Added a couple of Coverity tickets that come with a bunch of Nexus, Instrument, Logs, related issues.