Ticket #11087 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

RRFMuon has a property that violates the standards

Reported by: Martyn Gigg Owned by: Raquel Alvarez Banos
Priority: blocker Milestone: Release 3.4
Component: Muon Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

The system tests check whether the algorithm properties adhere to the Mantid standards (http://www.mantidproject.org/Mantid_Standards). The new RRFMuon algorithm has a property that violates these standards - Frequence units should be FrequencyUnits, so that it can be used from Python.

Could you fix this soon?

Change History

comment:1 Changed 6 years ago by Martyn Gigg

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from assigned to inprogress

comment:3 Changed 6 years ago by Raquel Alvarez Banos

Yes, I am working on it now, should be ready soon.

comment:4 Changed 6 years ago by Martyn Gigg

Thanks.

comment:5 Changed 6 years ago by Martyn Gigg

Could I also ask that the macros 

#define REAL(z,i) ((z)[2*(i)])
#define IMAG(z,i) ((z)[2*(i)+1])

are removed. It doesn't look like they are used?

comment:6 Changed 6 years ago by Raquel Alvarez Banos

Yes, I have just noticed that too. I will be removing them.

comment:7 Changed 6 years ago by Raquel Alvarez Banos

Re #11087 changing property name

Changeset: dfe3df8c7bd3895a04d73a7c533da42c4274464d

comment:8 Changed 6 years ago by Raquel Alvarez Banos

Re #11087 updating unit tests accordingly

Changeset: 73ebb536327331521bbdeda161fd4480d161061b

comment:9 Changed 6 years ago by Raquel Alvarez Banos

Re #11087 Removing unused macros

Changeset: 25902f45f06d94cc4f57f32dadc9ce79e19fbd69

comment:10 Changed 6 years ago by Raquel Alvarez Banos

Re #11087 fixing last occurrence

Changeset: 333345eb3f78595af024a9c9bf9fedecd035a64e

comment:11 Changed 6 years ago by Raquel

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #213.

comment:12 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:13 Changed 6 years ago by Raquel

Jenkins, retest this please

comment:14 Changed 6 years ago by Martyn Gigg

The *fedora-20-build* failed due to a git error that is most likely a problem on the machine. The other builds/tests are happy and the changes look fine. I will run the system tests locally to be sure.

comment:15 Changed 6 years ago by Martyn Gigg

The system tests are happy now :+1:

comment:16 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge pull request #213 from mantidproject/11087_rrfmuon_change_property_name

Fixing property name that violates the standards

Full changeset: ​7bf70c1b72f6c2bff2f7cfe4b896fc5dc38bae44

comment:17 Changed 6 years ago by Raquel

Ok, thanks Martyn

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11926

Note: See TracTickets for help on using tickets.