Ticket #11091 (closed: fixed)
Refactor InternetHelper class
| Reported by: | Nick Draper | Owned by: | Nick Draper |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.4 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Federico M Pouzols |
Description
This has developed rapidly and the argument lists have gotten messy, refactor towards a command pattern where you get and set properties before starting the request.
Change History
comment:2 Changed 6 years ago by Nick Draper
re #11091 mostly done, unit tests pass
Changeset: 9cac9f29e951cd3a2951705f74169ccbf6089514
comment:3 Changed 6 years ago by Nick Draper
re #11091 added another test
Changeset: 6c24e71adba371c8f6585f55099f51b5b3c6905e
comment:5 Changed 6 years ago by Nick Draper
- Status changed from assigned to verify
- Resolution set to fixed
comment:6 Changed 6 years ago by Nick Draper
tested as pull request https://github.com/mantidproject/mantid/pull/219
comment:7 Changed 6 years ago by Federico M Pouzols
- Status changed from verify to verifying
- Tester set to Federico M Pouzols
comment:8 Changed 6 years ago by Nick Draper
re #11091 added missing include
Changeset: f7ca977d66b6f13923d84a44a533d07877fadcab
comment:9 Changed 6 years ago by Nick Draper
re #11091 change stringstream to ostringstream usage
Changeset: 096f9835a3de34f1f8713cc0513845ff83f07e30
comment:10 Changed 6 years ago by Martyn Gigg
Jenkins, retest this please.
comment:11 Changed 6 years ago by Nick Draper
re #11091 fix linux bug
Changeset: 69ae3ddefc75553b84336f132981da509cac3e3c
comment:12 Changed 6 years ago by Martyn Gigg
Jenkins, retest this please.
comment:13 Changed 6 years ago by Federico M Pouzols
Both algorithms seem to work well and tests pass. The code looks good and it comes with additional tests, so I'd say this is ready.
comment:14 Changed 6 years ago by Nick Draper
re #11091 fix doxygen error
Changeset: 44286ac625eacfbfc897628875a4fccf0646db64
comment:15 Changed 6 years ago by Federico M Pouzols
Well, this was totally safe to merge before the last commit (doxygen parameter name) which should not break anything. The compilation failure on rhel6 and fedora20 happened because of a totatlly unrelated git issue. So I'm merging it in.
comment:16 Changed 6 years ago by Federico M Pouzols
- Status changed from verifying to closed
Merge pull request #219 from mantidproject/feature/11091_Refactor_internetHelper
Feature/11091 refactor internet helper
Full changeset: 1b8b39e69900de81b10ac208dc05d4156a24bf40
comment:17 Changed 5 years ago by Nick Draper
Somehow these slipped through without a resolution. Set to Fixed.
comment:18 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11930
