Ticket #11094 (closed: fixed)
Eradicate Coverity issues in ApplicationWindow.cpp
| Reported by: | Harry Jeffery | Owned by: | Harry Jeffery |
|---|---|---|---|
| Priority: | minor | Milestone: | Release 3.4 |
| Component: | Tools | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Federico M Pouzols |
Description (last modified by Harry Jeffery) (diff)
ApplicationWindow.cpp is a nest of coverity issues (Nearly 100!). They shouldn't take too long to remove, and would drop the number of open Coverity issues substantially.
Change History
comment:2 Changed 6 years ago by Harry Jeffery
- Status changed from assigned to inprogress
- Description modified (diff)
comment:3 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolves Coverity 1076227
Changeset: 5bb7b4cffe34136111e14e06de0c6147831e2d89
comment:4 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolves Coverity 1076226
Changeset: 147322223323972f90d7f58891c090892df1b967
comment:5 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolves Coverity 1076225
Changeset: 9995dbdddf687ebee29f363b4fc59d4b79740680
comment:6 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolves Coverity 1076224
Changeset: 35f4a4010ca18769dc2594758bb83b68fe0156e0
comment:7 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolves Coverity 1076223
Changeset: 7a4bcc849d64533a19390cd83c07d324dea106f1
comment:8 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolves Coverity 1076222
Changeset: c10576d64318a9cf234b9657b95ca81c432e767a
comment:9 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolves Coverity 1076221
Changeset: befa32a573655aaba01bfa3cb2a608ee149d3f92
comment:10 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolves Coverity 10762{19,20}
Changeset: dc9ea061c835b58c5bb50e7c5f403680cbc767a1
comment:11 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolves Coverity 1076218
Changeset: 119ae339cf2ec1b3a5b0a9157afefdbf46c77504
comment:12 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolves Coverity 1076217
Changeset: a9f367cf48783c4c4d3aad4cf891872590c153a8
comment:13 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolves Coverity 1076216
Changeset: b33e0371ffef1ef4283cd99049930760d7148e78
comment:14 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolves Coverity 1076215
Changeset: e19f7cf0181ae79b784662b68f82ecb2edc5d20b
comment:15 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolves Coverity 1076214
Changeset: 7afda07cc6155e74992dd4eaa494c4c0fae3397f
comment:16 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolves Coverity 10762{11,13}
Changeset: 7e12b3e10cc7b607d72c8dfa4704f60e72fe4a53
comment:17 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolves Coverity 1076212
Changeset: e6689c6e669def6bfe61971edb930532f21cc883
comment:18 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolves Coverity 1076210
Changeset: 81bebab1c34da1becc959f564f96186b52ecd10d
comment:19 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolves Coverity 1076209
Changeset: c54a505cdefb549db9454308c15187375afb0d28
comment:20 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in pasteSelection
Changeset: b295d10ba64159716905e9b157d948d2dde63db3
comment:21 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in changeMatrixName
Changeset: a59cb98b6753261ecb3ed7939a4fedf4377875e9
comment:22 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in clone
Changeset: e17288d8f23eca85b9e7493565e67957980086d9
comment:23 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in custom3DActions
Changeset: d0887d2a9b2004814d4cdcd5b1f752b198933a10
comment:24 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in customizeTables
Changeset: f2d97c7e4d0233dd529e8988605fb1e52f7461fe
comment:25 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in defineErrorBars
Changeset: 9e97a67a5d3cce55e02f1046ca1a8848e2e0e9c9
comment:26 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in deleteFitTables
Changeset: 604db70e1064ce1f8800dd18011dbfb1b3fb9067
comment:27 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in deleteSelectedItems
Changeset: 331b218413ce71082f51a514b5e91dfed3180c79
comment:28 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in depending3DPlots
Changeset: 7fed047a520869cabf244d7869b892415292e8a9
comment:29 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in dropFolderItems
Changeset: 9b374086281d1b5c193a40cf26677243075db429
comment:30 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in dependingPlots
Changeset: ddb2668056a13397eafbb660542112b08462b9b3
comment:31 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in editSurfacePlot
Changeset: a50619eeeb1ae9c7aa120008aa7fe864620c05c9
comment:32 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in exportAllGraphs
Changeset: 07a1a269237c8b9dde5847edc683478db1ccba40
comment:33 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in exportAllTables
Changeset: dbc9d4579b096711ccf4412c8ad7e5b624d968ba
comment:34 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in exportPDF
Changeset: db2301e388d687e2003fdf0d1fcadcaa5f3c223a
comment:35 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in folderItemChanged
Changeset: 68015ac732e749fb37a3c492a648465d534ca322
comment:36 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in folderItemDoubleClicked
Changeset: 5c2e27556cc4afa6fd27bb1dc4e329c3c763757e
comment:37 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in goToRow
Changeset: 2474d52321b37122269146b36d0569206ae1c7ce
comment:38 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in hideSelectedWindows
Changeset: ed90dbb22b20d56ce6dc4055f05a62a49eb5a36e
comment:39 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in insert3DMatrixPlot
Changeset: d9b0d184340b65e9964228e85334727305750b8c
comment:40 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in insertNew3DData
Changeset: d966782e299d9b8de5cc8564b2e3726862de3fbd
comment:41 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in integrate
Changeset: 02b3e12595201bc7cba2216194fff0b2ce00f979
comment:42 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in minimizeWindow
Changeset: 2596e11322705a378806d6552dce1672a26808b6
comment:43 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in multilayerDependencies
Changeset: fd0a7f83e72696bb8e0f36e4fcbdb6b5b9f2eefc
comment:44 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in print
Changeset: 655fd6da4029e1532b4f7489035e364d24e8a1f6
comment:45 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in projectFolder
Changeset: 09414e086d164d3a511191df2de3184dab88dc11
comment:46 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in recalculateTable
Changeset: 3c5782ecc51cf01555cbd2b507d089d06b2cf77d
comment:47 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in redo
Changeset: 3d75bf589d33814faf7a633c3f1b897bb9b7fefb
comment:48 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in remove3DMatrixPlots
Changeset: 2f3546c5eab0239c236526ada88f3176f71e6cfc
comment:49 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in removeErrorBars
Changeset: 7edfda6c34d4f5691eb3d167cef78f56ea8327b9
comment:50 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in removeWindowFromLists
Changeset: a2d141d433990f6d0c64fabdb67153576f06344d
comment:51 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in setGraphDefaultSettings
Changeset: c6c55b6ee46cb5834f8f475059d0de43ff97741c
comment:52 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in setMatrixUndoStackSize
Changeset: 884fdea8f73e1869bc8f73a846b257cd3df6439b
comment:53 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in setPlot3DOptions
Changeset: c9420b312bc44a4c69470cc52aaeb773cd6dbf13
comment:54 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in showAllFolderWindows
Changeset: e11fb508498a15d5f7cdee6028fd8ce79a85f374
comment:55 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in showAxisDialog
Changeset: 4a3c6ee85be11765e59718173b509d9e7deb7a21
comment:56 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in showAxisTitleDialog
Changeset: 8434e6b5953c02577251eeece32bad73ef68e4f3
comment:57 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in showCurveWorksheet
Changeset: 54d522ca934314b31876952ffe0cf89f29fc578d
comment:58 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in showCurvesDialog
Changeset: 9a361fc31ba03ce4a0619864994891af84a446f2
comment:59 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in showFolderPopupMenu
Changeset: aaeecfe453284dfb0fd517f9c9d6eadc89274953
comment:60 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in showGraphContextMenu
Changeset: f16b0cd722d3e2efa20a9307b908d6d41873e9d1
comment:61 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in showPlotAssociations
Changeset: ded79973b2f13f2181059bcfa207d4c37ea8b241
comment:62 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in showScaleDialog
Changeset: bac19413f710e6455379e8e0b7f6d6ca3999d871
comment:63 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in showSelectedWindows
Changeset: 80935443e31aed512a39623ed666120a41c7fb9e
comment:64 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in showTitleDialog
Changeset: 73905a87a99d0e51990d466e9399b7c4fac05c6a
comment:65 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in showWindowContextMenu
Changeset: 4464ba428582f0bcc78175aa6109288043676b3d
comment:66 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in showWindowPopupMenu
Changeset: 445de3e685b12a0c6947080a26a4d8b64eeacc98
comment:67 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in startRenameFolder
Changeset: 9cf4ee23f8df81c491e9d0f9dd657168eea504d1
comment:68 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in undo
Changeset: 922a393a03450eef4697a6dc490ec5380beb5ed7
comment:69 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in updateColNames
Changeset: 0a6fc572af9e9de81297c8303e1844f19df9be6c
comment:70 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in updateTableNames
Changeset: 8eea26c8a186a4051c7de30e9baedb4a30883cef
comment:71 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in windowProperties
Changeset: 545aedb14d3aa132c41e6a227db2c33b34c45737
comment:72 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in updateMatrixPlots
Changeset: f5e6c385c17f06e05f729f0285f01f9beaa81481
comment:73 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in open
Changeset: d0efde6c59b3036242c5901dc09ad04acddd092e
comment:74 Changed 6 years ago by Harry Jeffery
Refs #11094 Resolve Coverity issues in appendProject
Changeset: a5b71390cbd802b605333e2584dffd0eb47a4c72
comment:75 Changed 6 years ago by Harry Jeffery
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #224.
comment:76 Changed 6 years ago by Federico M Pouzols
- Status changed from verify to verifying
- Tester set to Federico M Pouzols
comment:77 Changed 6 years ago by Federico M Pouzols
This is what I call a brave effort :) MantidPlot was so much in need of this. I'll review it but all looks fine at first glimpse.
The build failed because of a random test failure on rhel6. I've seen that one before (TEST-AlgorithmsTest.RemoveExpDecayTest) some days ago. Not sure what's randomly wrong with it.
comment:78 Changed 6 years ago by Federico M Pouzols
All looks good to me. I just have a few comments that I'm writing inline. Let me know if those are worth fixing and I'll merge the branch.
Oh, in principle this looked ready to be merged in, but it seems that a merge conflict has popped up?
comment:79 Changed 6 years ago by Harry Jeffery
Merge branch 'master' into 11094_eradicate_coverity_issues_in_appwindow
Refs #11094
Changeset: 0cb4e3d748c0d394a378090338a36d2c04d78740
comment:80 Changed 6 years ago by Harry Jeffery
Okay, I've resolved the merge conflict - but I've not yet gone through your feedback :)
comment:81 Changed 6 years ago by Federico M Pouzols
Good, I've added all my comments now. Take those just as suggestions from a paranoid mind ;)
comment:82 Changed 6 years ago by Harry Jeffery
Okay, I dug into the classes you highlighted, and the pointers you referred to appear to be created or initialised in the constructors, so they'll always be valid.
It ought be safe to merge this branch without further changes.
comment:83 Changed 6 years ago by Federico M Pouzols
Hum, the merge build failed on osx because of the git checkout issue. False alarm. I think it's safe to merge this in before more conflicts arise.
comment:84 Changed 6 years ago by Federico M Pouzols
Jenkins, retest this please
comment:85 Changed 6 years ago by Harry Jeffery
The only failures now seem to be the flaky RemoveExpDecay test. Ought to be safe to merge.
comment:86 Changed 6 years ago by Federico M Pouzols
At last it compiled on all platform and the test failures are absolutely not related to this.
It seems that there's a merge conflict again though.
comment:87 Changed 6 years ago by Harry Jeffery
Merge branch 'master' into 11094_eradicate_coverity_issues_in_appwindow
Refs #11094
Changeset: ce2d241051bd08ef5e6749a3a08092125f0b665e
comment:88 Changed 6 years ago by Harry Jeffery
This is actually the exact same merge conflict, but in reverse, as a result of #103 being reverted.
comment:89 Changed 6 years ago by Federico M Pouzols
- Status changed from verifying to closed
Merge pull request #224 from mantidproject/11094_eradicate_coverity_issues_in_appwindow
Eradicate coverity issues in ApplicationWindow.cpp
Full changeset: f5517ac9ed92f6bf2b231b402b64a01119ca41fd
comment:90 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11933
