Ticket #11098 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Load SPICE data file for 2D detetor

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: major Milestone: Release 3.4
Component: Diffraction Keywords:
Cc: petersonpf@…, saviciat@… Blocked By:
Blocking: Tester: Federico Montesino Pouzols

Description

Implement a new algorithm to load 2D-detector SPICE file for HB3A. The file in a new format is written to an XML file for each measurement. In another word, each traditional SPICE data file corresponds to N such XML files if there are N measurement points in the experiment run.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Wenduo Zhou

  • Status changed from assigned to inprogress

comment:3 Changed 6 years ago by Wenduo Zhou

Refs #11098. Added algorithms files and data file.

On branch feature/11098_hb3a_2ddata

  • modified: ../../../Framework/DataHandling/CMakeLists.txt
  • new file: ../../../Framework/DataHandling/inc/MantidDataHandling/LoadSpiceXML2DDet.h
  • new file: ../../../Framework/DataHandling/src/LoadSpiceXML2DDet.cpp
  • new file: ../../../Framework/DataHandling/test/LoadSpiceXML2DDetTest.h
  • new file: HB3A_exp355_scan0001_0522.xml.md5

Changeset: d74ba3f702ee01b169f19df935fc3d0dd1a40b37

comment:4 Changed 6 years ago by Wenduo Zhou

Checkpointing progress. Refs #11098.

Changeset: c444ec895d5bcbfc3aede628a6df2b4cb51850c6

comment:5 Changed 6 years ago by Wenduo Zhou

Refs #11098. Checkpointing progress in XML parser.

Changeset: d99e790efa8616b7ebbab32b01abedaa6357afa5

comment:6 Changed 6 years ago by Wenduo Zhou

Refs #11098. Checkpointing progress on parsing XML.

Changeset: 4538f136cbfeec37d8272470663841dccc319b02

comment:7 Changed 6 years ago by Wenduo Zhou

Fixed some minor issue and add doc. Refs #11098.

Changeset: 10ff30defc613c855331d6dbccdba99e75896f89

comment:8 Changed 6 years ago by Wenduo Zhou

Implemented log value handling. Refs #11098.

Changeset: 9e7cbfb1346a6348f6b9bcfa64e9c8a4e2d7100f

comment:9 Changed 6 years ago by Wenduo Zhou

Added more to unit tests. Refs #11098.

Changeset: bbf4dcb2a67640385093582df0806cad36509053

comment:10 Changed 6 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #365.

comment:11 Changed 6 years ago by Wenduo Zhou

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:12 Changed 6 years ago by Wenduo Zhou

  • Status changed from reopened to inprogress

comment:13 Changed 6 years ago by Wenduo Zhou

Refs #11098. Enabled to parse start_time and end_time.

And cleaned the debugging output as well.

Changeset: 80138c17c17e1234f40fbbe5748bce59dee6152c

comment:14 Changed 6 years ago by Wenduo Zhou

Fixed ms warnings. Refs #11098.

Changeset: fbdf5bb2078b46eb05005aa3f3343679c7593c48

comment:15 Changed 6 years ago by Wenduo Zhou

retest please.

comment:16 Changed 6 years ago by Wenduo Zhou

Please

comment:17 Changed 6 years ago by Wenduo Zhou

test this please

comment:18 Changed 6 years ago by Wenduo Zhou

Refs #11098. Added usage example.

Changeset: c98fbe82c2f8bea366e27b6e2be2949bd5849201

comment:19 Changed 6 years ago by Wenduo Zhou

Tried to fix example test. Refs #11098.

Changeset: b20a1e3d716fabbb9e9102849ac746747355e9a4

comment:20 Changed 6 years ago by Wenduo Zhou

Tried to fix example test. Refs #11098.

Changeset: 2d1adf8280503825375a4db3cc7e68542936fedb

comment:21 Changed 6 years ago by Wenduo Zhou

Refs #11098. Fixed example script.

Changeset: 380948561da01c38a0eb3a226afe48ca811e23c2

comment:22 Changed 6 years ago by Wenduo Zhou

Completed the doc. Refs #11098.

Changeset: 608057284c4140dfe2aef24d2d8d549987177f47

comment:23 Changed 6 years ago by Wenduo Zhou

For tester: A new algorithm LoadSpiceXML2DDet is implemented in this algorithm. In order to test, you can download any XML files of HFIR's HB3A from http://neutron.ornl.gov/user_data/hb3a/exp355/Datafiles/. You may run the algorithm to load data and check the output MatrixWorkspace including the spectra and sample logs.

comment:24 Changed 6 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:25 Changed 6 years ago by Wenduo Zhou

retest please.

comment:26 Changed 6 years ago by Wenduo Zhou

retest this please

comment:27 Changed 6 years ago by Wenduo Zhou

Jekins, test this please.

comment:28 Changed 6 years ago by Federico Montesino Pouzols

Jenkins, retest this please

comment:29 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico Montesino Pouzols

comment:30 Changed 6 years ago by Federico Montesino Pouzols

Code looks very good and it comes with a unit test and doc tests. I think it's ready to be merged in.

I only spotted a very minor issue with a doxygen tag (see inline comment above). Please have a look at it, and I'll merge this PR. I'd also suggest adding a short description of the parameters if there's any point that needs to be clarified (like expected format, typical usage, etc.).

comment:31 Changed 6 years ago by Federico Montesino Pouzols

Just another comment. I tested the algorithm with a few example XML files from the link that you posted above. Everything seems to work well. Maybe in the future a default value for the 'DetectorGeometry' could be guessed from the file? For interactive use it would be convenient, although I'm not sure if this algorithm will be used directly, or just as part of the HFIR HB3A load/reduce workflow.

comment:32 Changed 6 years ago by Federico Montesino Pouzols

OH and another comment, could you add the ticket number for this?

comment:33 Changed 6 years ago by Wenduo Zhou

Fixed some issue on doxygen. Refs #11098.

Changeset: 5a445eda3e57c4a67644f422a0ce6bf880ddb062

comment:34 Changed 6 years ago by Federico Montesino Pouzols

We got a glitch on the win7 build, so I stopped the builds that were still running. Let's try again...

comment:35 Changed 6 years ago by Federico Montesino Pouzols

Jenkins, retest this please

comment:36 Changed 6 years ago by Federico Montesino Pouzols

Jenkins, retest this please

comment:37 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from verifying to closed

Merge pull request #365 from mantidproject/feature/11098_hb3a_2ddata

New algorithm to load SPICE XML data

Full changeset: 5e03002a084af2d8e4db469c0757ff3b6ff76983

comment:38 Changed 5 years ago by Nick Draper

  • Component changed from Framework to Direct Inelastic

comment:39 Changed 5 years ago by Andrei Savici

  • Component changed from Direct Inelastic to Diffraction

comment:40 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11937

Note: See TracTickets for help on using tickets.