Create a FileBackedExperimentInfo class

[Ian Bush]

Create a class that inherits from ExperimentInfo, but lazy loads the experiment information. Otherwise should behave the same as the parent class.

[Ian Bush]

Refs #11101 Initial commit with some of the class structure.

Changeset: b94b3f4ea6d2d229ccf4a296ad0a5b237098d27a

[Ian Bush]

Refs #11101 Constructor wired up properly.

Changeset: 775f952fa51a69375788a3b3c71ccde377754b7e

[Ian Bush]

Refs #11101 Added overwridden method for toString.

Changeset: f67fc4e4b3e3b488dac18153ce89a6d2e86fe00e

[Ian Bush]

Refs #11101 Unit test for toString method. Fixes to coding style.

Changeset: d1651b2820a44bb839f6eaa66bc6ef9724fdb88f

[Ian Bush]

Refs #11101 Fixed toString unit test, to test as intended.

Changeset: c3b77604b4b6bcae6fc07435b674e6d015f05a90

[Ian Bush]

I have started work on this, but this is likely as far as I will be able to get before passing it on to someone else.

Currently the test case is for MD files, but the method should be general for any NeXus file with experiment info.

Most of the other methods contained in ExperimentInfo will need similar treatment to the toString method, in terms of implementation and testing.

[Martyn Gigg]

Clang format the files.

Refs #11101

Changeset: 82fb6614f8bd8cfb159dc3f8de16e90227a29428

[Martyn Gigg]

Clean up of code and extend the test.

Refs #11101

Changeset: bfbc41ed573da8d2c6866b8925b897e5dd95c247

[Martyn Gigg]

Add boilerplate methods to create test using new

This avoids the HistoryView constructor running when other tests are run. Refs #11101

Changeset: 74daa59d9d4bdd31e0aec97ec6a2a08909dd91d8

[Martyn Gigg]

Avoid a warning written to stderr by NeXus.

Refs #11101

Changeset: 432d9b9020d2300ed2841138367ce0c288b9aad9

[Martyn Gigg]

Virtualise base class methods appropriately.

Refs #11101

Changeset: f1d09bf0c9396d6657c2636fad04a35e68f74858

[Martyn Gigg]

Checkpoint current status.

Switched file to HRPD file to improve speed. Refs #11101

Changeset: 3f76a29a5b9579660361fe74c143efa0ebdd70cc

[Martyn Gigg]

Run clang-format on the test.

Refs #11101

Changeset: f99093e939c68b576317937bc89ceaa1716a47fb

[Martyn Gigg]

Add further method overrides for the file backed class

Refs #11101

Changeset: 9580f0480a0f58c7292617ba91466c5d3338e98a

[Martyn Gigg]

Add further method overrides for the file backed class

Refs #11101

Changeset: 088f3b91fb90b303407012ee2f7b46a73ca1c2fb

[Martyn Gigg]

Better utilisation of branch prediction

Places the most likely code path first. Refs #11101

Changeset: 8f0de0ea303e6ce9702a9a06a33cca3f51f5b4d7

[Martyn Gigg]

Implement the remaining methods on ExperimentInfo + tests

Refs #11101

Changeset: 2f91c82a28b68905f9c96b3edfc866543223a501

[Martyn Gigg]

Clang format the files.

Refs #11101

Changeset: 72f11bb8a5bc1436c38c450cd0d21d6fabf83d06

[Martyn Gigg]

Remove debugging print statements.

Refs #11101

Changeset: 6182367a41a7e435de205b17db283c8d2695ce31

[Martyn Gigg]

This is being verified as ​pull request #307.

[Martyn Gigg]

Fix constness of mock method.

Refs #11101

Changeset: 76d2b589436a184c8e020f50711605ba886a8689

[Martyn Gigg]

Remove outdated comments.

Refs #11101

Changeset: 14add7e2c0564a3819ef43cd13ec694e8781034e

[Martyn Gigg]

Jenkins, retest this please

[Martyn Gigg]

Jenkins, retest this please

[Federico M Pouzols]

Jenkins, retest this please...

[Federico M Pouzols]

There's a a couple of places in FileBackedExperimentInfoTest.h where the intel compiler and old gcc cannot cope with boost::make_shared<::NeXus::File> (lines 38 and 240) because of the <::.

[Martyn Gigg]

Thanks, I thought I'd caught all of those.

[Martyn Gigg]

Fix usage of ::NeXus::File as template parameter

Some compilers don't like the colon next to the bracket. Refs #11101

Changeset: bb926fbfad20b1b7be1d1d25286d6e2e5f10ea42

[Martyn Gigg]

Jenkins, retest this please

[Federico M Pouzols]

Jenkins, retest this please

[Federico M Pouzols]

MSVC is now complaining with some warnings that come from NeXusStream.hpp. Strange, I hadn't seen those in the previous build.

[Martyn Gigg]

I hadn't seen that either. It must be from the NeXus inclusion in the unit test. The warning is actually something we have to suppress anyway and this is usually done in System.h but it is not included before the NeXus include here at the moment. I'll move the include.

[Martyn Gigg]

Move include line so that a warning is suppressed.

Refs #11101

Changeset: c9308d7af8f90d6be98f5cc7f311771209999fd1

[Martyn Gigg]

That seems to have fixed the warnings now.

[Federico M Pouzols]

All compilers are happy now. The code looks really neat, well organized, documented and tested. Ready for further work in LoadMD.

[Martyn Gigg]

Fix usage of ::NeXus::File as template parameter

Some compilers don't like the colon next to the bracket. Refs #11101

Changeset: bb926fbfad20b1b7be1d1d25286d6e2e5f10ea42

[Martyn Gigg]

Move include line so that a warning is suppressed.

Refs #11101

Changeset: c9308d7af8f90d6be98f5cc7f311771209999fd1

[Federico M Pouzols]

Merge pull request #307 from mantidproject/11101_lazy_load_experiment_info

Implement a lazy loading ExperimentInfo class

Full changeset: ​f8fdbf188fbf77024d492c8d36c4a94cb693b2c5

[Nick Draper]

Somehow these slipped through without a resolution. Set to Fixed.

[Stuart Campbell]

This ticket has been transferred to github issue ​11940