PoldiSpectrumConstantBackground causes a compilation error with gcc 4.9.1

[Michael Wedel]

When compiling Mantid with gcc 4.9.1 (for example in Ubuntu 14.10), the compiler gives the following error:

Framework/SINQ/test/PoldiSpectrumConstantBackgroundTest.cpp: In member function ‘void PoldiSpectrumConstantBackgroundTest::testParameterCount()’:
   Framework/SINQ/test/PoldiSpectrumConstantBackgroundTest.cpp:40:80: internal compiler error: in possible_polymorphic_call_targets, at ipa-devirt.c:1557
    } testDescription_suite_PoldiSpectrumConstantBackgroundTest_testPoldiFunction1D;

Experiments revealed that making the inheritance virtual gets rid of the error.

[Michael Wedel]

This is being verified as ​pull request #231.

[Michael Wedel]

Testing information This needs to be verified by someone with gcc 4.9.1, because in the gcc version used in Ubuntu 14.04 this did not cause the error message. So please make sure everything compiles with gcc 4.9.1 and the PSISINQTEST unit tests still pass, as well as the system tests.

[Michael Wedel]

Jenkins retest this please

[Andrei Savici]

Merge pull request #231 from mantidproject/11109_fix_gcc_491_error_poldi_constant_backgroun

Fix error caused by PoldiSpectrumConstantBackground with some compilers

Full changeset: ​4742c0682dc1ff5941afedcafdd8e99a9c0b3029

[Andrei Savici]

Works on Ubuntu 14.10

[Stuart Campbell]

This ticket has been transferred to github issue ​11948