Ticket #11115 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Re-enable unit tests in GaussianTest.h

Reported by: Michael Wedel Owned by: Roman Tolchenov
Priority: major Milestone: Release 3.4
Component: Framework Keywords: Fitting
Cc: Blocked By:
Blocking: Tester: Dan Nixon

Description

Some of the unit tests in GaussianTest.h are disabled. Two of them could be re-enabled in connection with #11104, but the following unit tests have some issues (failing assertions, problems with data types): 

t11estAgainstPeak2FallbackToSimplex
xtestAgainstMockData
t11estAgainstHRPD_DatasetWithConstraintsSimplex

These three tests should be re-enabled and fixed - or removed if they don't apply anymore.

Change History

comment:1 Changed 6 years ago by Roman Tolchenov

Re #11115. Fixed the tests.

Changeset: 70ada56493efa09c91819f04f7cc571b498ddb4e

comment:2 Changed 6 years ago by Roman Tolchenov

  • Status changed from new to verify
  • Resolution set to fixed

This is being verified as ​pull request #246.

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester set to Dan Nixon

comment:4 Changed 6 years ago by Roman Tolchenov

Jenkins, retest this please

comment:5 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge pull request #246 from mantidproject/11115_enable_gaussian_tests

Enable Gaussian tests.

Full changeset: ​3272eacd19a016e3815b04f3141e72ba905651a4

comment:6 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11954

Note: See TracTickets for help on using tickets.