Ticket #11120 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

fix osx+clang build and LoadGSASInstrumentFileTest.h

Reported by: Steven Hahn Owned by: Steven Hahn
Priority: critical Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description (last modified by Steven Hahn) (diff)

Changes to LoadGSASInstrumentFileTest.h result in build not compiling on clang. Instead of reusing paramMap, we use another variable, paramMap2.

Change History

comment:1 Changed 6 years ago by Steven Hahn

Refs #11120. For the second workspace, rename paramMap with paramMap2.

Changeset: 4d2bd72846faf3d6d5b3b74768249c89b8e7d2c7

comment:2 Changed 6 years ago by Steven Hahn

  • Status changed from new to verify
  • Resolution set to fixed

This is being verified as ​pull request #244.

comment:3 Changed 6 years ago by Steven Hahn

  • Description modified (diff)

comment:4 Changed 6 years ago by Steven Hahn

  • Description modified (diff)

comment:5 Changed 6 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:6 Changed 6 years ago by Steven Hahn

retest this please

comment:7 Changed 6 years ago by Steven Hahn

retest this please

comment:8 Changed 6 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge pull request #244 from mantidproject/11120_fix_clang_error

osx+clang fix for LoadGSASInstrumentFileTest

Full changeset: ​a7bc302e7f90e0b0e0d315b93351cdbcf2d02fdb

comment:9 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11959

Note: See TracTickets for help on using tickets.