Context Navigation

← Previous Ticket
Next Ticket →

Ticket #11125 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Ability to copy detector mapping form one workspace to another

Reported by:	Dan Nixon	Owned by:	Dan Nixon
Priority:	major	Milestone:	Release 3.4
Component:	Framework	Keywords:
Cc:	spencer.howells@…, Alex.Buts@…	Blocked By:
Blocking:		Tester:	Raquel

Description (last modified by Dan Nixon) (diff)

Currently there is no simple way to copy the detector mapping from on workspace to another, this functionality is somewhat present in SpectrumDetectorMapping and should be wrapped in an algorithm.

Note the intended use for this algorithm is to be part of Python workflow algorithms, it is not something a user would usually do directly on workspaces.

Change History

comment:1 Changed 6 years ago by Dan Nixon

Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

Status changed from assigned to inprogress

Initial version of CopyDetectorMapping algorithm

Refs #11125

Changeset: 98a23b707ef9637e62c857015cc95b1cdba80022

comment:3 Changed 6 years ago by Dan Nixon

Add test and validation for equal histogram counts

Refs #11125

Changeset: 8858b6255a61035d9428e2a32f38130cb1e39548

comment:4 Changed 6 years ago by Dan Nixon

Add documentation for CopyDetectorMapping

Refs #11125

Changeset: 6e70159bddb2d4249161a63e59a0bb91977c5eb7

comment:5 Changed 6 years ago by Dan Nixon

Description modified (diff)

comment:6 Changed 6 years ago by Dan Nixon

Status changed from inprogress to verify
Resolution set to fixed

This is being verified as pull request #249.

comment:7 Changed 6 years ago by Dan Nixon

Set default value of member variables correctly

Refs #11125

Changeset: 6645db651a4c26c89bbbc66a435d615b4ab09716

comment:8 Changed 6 years ago by Raquel

Status changed from verify to verifying
Tester set to Raquel

comment:9 Changed 6 years ago by Raquel

Code and unit test look nice, well documented as well. I have just noticed an issue: when dealing with workspace groups Mantid crashes. This is confusing when you only have one workspace group loaded in Mantid and then you execute the algorithm, as it crashes without information. Given the purpose of the algorithm I may not make much sense trying to use workspace groups, but an error message would be useful.