Ticket #11131 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

More accurate calculation of the width and other peak parameters

Reported by: Roman Tolchenov Owned by: Roman Tolchenov
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Michael.Wedel@… Blocked By:
Blocking: Tester: Michael Wedel

Description

Some peak functions do not return accurate peak parameters (centre, height, width). Implement generic methods on IPeakFunction to get/set those parameters using numerical methods.

Change History

comment:1 Changed 6 years ago by Roman Tolchenov

Re #11131. Numerical calculation of centre, height and width.

Changeset: 5269c123caeda2e2e85af83c954c6adf92fd0263

comment:2 Changed 6 years ago by Roman Tolchenov

Merge remote-tracking branch 'origin/master' into 11131_peak_centre_height_width

Conflicts:

Code/Mantid/Framework/CurveFitting/inc/MantidCurveFitting/BackToBackExponential.h Code/Mantid/Framework/CurveFitting/test/BackToBackExponentialTest.h

Re #11131.

Changeset: cf8dd2a8c0dfef6c9f6377d4f95fd0be5bb06dd7

comment:3 Changed 6 years ago by Roman Tolchenov

  • Status changed from new to inprogress

Re #11131. ChebfunBase unit tests. Formatting.

Changeset: a664f023a1c17aeba34d5491560edc3b877e5bff

comment:4 Changed 6 years ago by Roman Tolchenov

Re #11131. Doxygen comments.

Changeset: db66da5fcaa5ee0fd0b58071c0514788781b01e4

comment:5 Changed 6 years ago by Roman Tolchenov

Merge remote-tracking branch 'origin/master' into 11131_peak_centre_height_width

Conflicts:

Code/Mantid/Framework/CurveFitting/CMakeLists.txt

Re #11131.

Changeset: 9cc61635b9107c3b471c91f66c8b4b7337d397f9

comment:6 Changed 6 years ago by Roman Tolchenov

Re #11131. Unit tests for numeric parameter calculations.

Changeset: d12cf0441f0d17dbfabe23bb9530643f836ec6ea

comment:7 Changed 6 years ago by Roman Tolchenov

Re #11131. Fix gcc error and warnings.

Changeset: 4c949ce5c3b4a72dab8acfea6fde5a3215b41929

comment:8 Changed 6 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #355.

comment:9 Changed 6 years ago by Michael Wedel

  • Status changed from verify to verifying
  • Tester set to Michael Wedel

comment:10 Changed 6 years ago by Michael Wedel

  • Status changed from verifying to closed

Merge pull request #355 from mantidproject/11131_peak_centre_height_width

The windows build failed, but on something completely unrelated. In addition I also ran the system test in question locally (Ubuntu 14.04) and it passed. After checking back with Martyn we agreed that it's okay to merge.

Full changeset: 2db86487ac6935058815b26abc7ad141937dc43a

comment:11 Changed 6 years ago by Roman Tolchenov

Re #11131. Reverted changes to default values in BackToBack.

Changeset: e3cca0b63310978fc4ddec834caef132ebf060a8

comment:12 Changed 6 years ago by Roman Tolchenov

Re #11131. Forgot that lambdas aren't allowed :(

Changeset: 12267d9255fe35763c1d6e18804a00dc5763c5a6

comment:13 Changed 6 years ago by Roman Tolchenov

Re #11131. Fixing the unit test.

Changeset: 5ec596383a168ee53bbefda855b128ecd4f68528

comment:14 Changed 6 years ago by Roman Tolchenov

Re #11131. Correction for a case of h0 == 0.

Changeset: a0623f37df9c44f1d879f7fa04cdb714e53cc6ba

comment:15 Changed 6 years ago by Roman Tolchenov

comment:16 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11970

Note: See TracTickets for help on using tickets.