Ticket #11140 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

CreateGroupingWorkspace fails if number of groups exceeds number of spectra in component

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

For example, this call:

grouping_ws = CreateGroupingWorkspace(InstrumentName='IRIS', FixedGroupCount=52, ComponentName='graphite')

gives this error:

fish: Job 1, “./bin/MantidPlot” terminated by signal SIGFPE (Floating point exception)

Because it requests 52 groups but there are only 51 spectra in the graphite component of IRIS.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Better handle the failure when num groups > num spectra in component

Refs #11140

Changeset: ac0cfd7aa97c4cb0a92121692c1c582eb275eca5

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #262.

comment:4 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:5 Changed 6 years ago by Martyn Gigg

The fix is fine and works as expected.

I tried a negative number for the FixedGroupCount property and it accepted it but created an empty group. I think that, while we are changing the algorithm, it is worth adding a BoundedValidator to the FixedGroupCount property so that it cannot be negative.

comment:6 Changed 6 years ago by Dan Nixon

Add bounded validator to keep group count property positive

Refs #11140

Changeset: f24639d32ec59f217a70e419b4ef7a5c887543ab

comment:7 Changed 6 years ago by Martyn Gigg

:+1:

comment:8 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge pull request #262 from mantidproject/11140_creategroupingworkspace_handle_group_count_failure

Handle failure in CreateGroupingWorkspace where group count > spectra count

Full changeset: a74480639470b7b3cf0d1ac12fc4a9262ca7b866

comment:9 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11979

Note: See TracTickets for help on using tickets.