Ticket #11141 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Improve confidence method in LoadMcStas

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: minor Milestone: Release 3.4
Component: Framework Keywords:
Cc: Torben.Nielsen@…, martyn.gigg@… Blocked By:
Blocking: Tester: KarlPalmen

Description

Make use of descriptor in this method to check at an earlier stage whether it is necessary to proceed with further check. This helps speed Load up in general.

Change History

comment:1 Changed 6 years ago by Anders Markvardsen

  • Status changed from new to assigned

This ticket generated from investigation in #9211 with Martyn

comment:2 Changed 6 years ago by Anders Markvardsen

  • Status changed from assigned to inprogress

updates to confidence() method. Re #11141

Changeset: 09b9aa4320ccba7944e3d918de95aedfa97ad412

comment:3 Changed 6 years ago by Anders Markvardsen

AutoTestData now External Data. re #11141

Changeset: b9dd256f56af48af4ce140cb35abbf5c9ca12930

comment:4 Changed 6 years ago by Anders Markvardsen

  • Cc Torben.Nielsen@…, martyn.gigg@… added

comment:5 Changed 6 years ago by Martyn Gigg

Jenkins, retest this please.

comment:6 Changed 6 years ago by Martyn Gigg

Could you update the title of the pull request to use be a short descriptive sentence rather than the branch name?

comment:7 Changed 6 years ago by KarlPalmen

  • Status changed from inprogress to closed
  • Tester set to KarlPalmen

Merge pull request #269 from mantidproject/feature/11141_confidence_method_mcstas

Improve confidence method in LoadMcStas by using descriptor - improved use of descriptor making code simpler and faster.

Full changeset: ​b7ef21575c647d8d812f815e5b8b60593dbaca5a

comment:8 Changed 5 years ago by Nick Draper

  • Resolution set to fixed

Somehow these slipped through without a resolution. Set to Fixed.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11980

Note: See TracTickets for help on using tickets.